<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110855/">http://git.reviewboard.kde.org/r/110855/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 8th, 2013, 7:02 a.m. UTC, <b>Vedant Agarwala</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems like a good patch. Did you test it with any script? It will be better if you do and even better if you attach a screen shot of that depicts the working.</pre>
</blockquote>
<p>On June 10th, 2013, 8:41 p.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your review, Vedant. We welcome patch reviews from non-members of the core Amarok team and you've pointed out things I would point out too (method name, trailing whitespace, style..). However, please state that you are not (yet) a member of the core Amarok development team in such reviews to reduce any possible confusion. Best is probably to present the review as a couple of non-binding friendly suggestions from a fellow contributor, not necessarily endorsed by The Amarok Team.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok Matej will do that in the future. I felt the same after he fixed the issues and I couldn't do anything there after, like a core member would have.
And Shubham, sorry if there was any confusion. As you may have understood, I'm just a fellow contributor.</pre>
<br />
<p>- Vedant</p>
<br />
<p>On June 8th, 2013, 6:32 p.m. UTC, Shubham Chaudhary wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Shubham Chaudhary.</div>
<p style="color: grey;"><i>Updated June 8, 2013, 6:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug 205509 - JJ: add dbus functions to update podcasts and download podcast tracks
I added two new methods for dbus: UpdateAllPodcast and AddPodcast</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested both of these methods using qdbus
qdbus org.kde.amarok /TrackList AddPodcast "http://feeds.feedburner.com/freakonomicsradio"
qdbus org.kde.amarok /TrackList UpdateAllPodcast</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=205509">205509</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=Bug">Bug</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml <span style="color: grey">(ee512b7)</span></li>
<li>src/dbus/mpris1/TrackListHandler.cpp <span style="color: grey">(b1f01cf)</span></li>
<li>src/dbus/mpris1/TrackListHandler.h <span style="color: grey">(551999a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110855/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>