<div dir="ltr">This is the review request: <a href="https://git.reviewboard.kde.org/r/110426/">https://git.reviewboard.kde.org/r/110426/</a>. I have trimmed the diff so that it contains code that affect only the MagnatuneConfig. Please review.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 14, 2013 at 10:59 PM, vedant agarwala <span dir="ltr"><<a href="mailto:vedant.kota@gmail.com" target="_blank">vedant.kota@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Mark,<div>I don't know what is wrong. I had fixed the compile time errors.</div><div>This is the link to the "make" output after freshly applying the patch I mailed you: <a href="http://paste.kde.org/743792/" target="_blank">http://paste.kde.org/743792/</a>. Line 3 shows that the class was compiled correctly and by Line 16 and onwards, I understand that the error is a linker error. Or am I missing something?</div>
<div>I am making a few changes and will upload a similar patch to the reviewboard in a few minutes. It will be easier to review there even though the code won't compile as it is.</div><div><br></div><div>
Regards,</div><div>Vedant</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 14, 2013 at 10:32 PM, Mark Kretschmann <span dir="ltr"><<a href="mailto:kretschmann@kde.org" target="_blank">kretschmann@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Vedant<br>
<br>
I tried to build the patch that you sent me, but there were so many<br>
compiler errors (>10) that I didn't even get to the linking stage.<br>
Missing member variables, missing copy constructor, etc etc.<br>
<br>
Please fix these errors first, then we can look at your linking issue.<br>
<br>
<br>
Mark<br>
<div><div><br>
<br>
On Tue, May 14, 2013 at 3:29 PM, vedant agarwala <<a href="mailto:vedant.kota@gmail.com" target="_blank">vedant.kota@gmail.com</a>> wrote:<br>
> Hello,<br>
> I need help in editing the cmakelists.txt.<br>
> I have created a KWalletHelper.h|cpp in the "src/services" directory. I<br>
> added the KWalletHelper.cpp to the src/cmakelists.txt (inside "set" of<br>
> SERVICEFRAMWORK). The class is compiling but then throwing linking errors<br>
> during link-time. I edited the src/services/magnatune/cmakelists.txt to add<br>
> it to the "target_link_libraries" but no avail. I think I am doing it wrong<br>
> here.<br>
> Any help would be greatly appreciated.<br>
> Thanking-you,<br>
> Vedant<br>
><br>
><br>
> On Sat, Apr 27, 2013 at 4:17 PM, vedant agarwala <<a href="mailto:vedant.kota@gmail.com" target="_blank">vedant.kota@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Hello,<br>
>> Seems like this is turning out to be an important feature. Surely now I<br>
>> will change the GpodderServicer code to connect to the "KWalletHelper" class<br>
>> in my upcoming review request.<br>
>><br>
>> Regards,<br>
>> Vedant.<br>
>><br>
>><br>
>><br>
>> On Sat, Apr 27, 2013 at 3:52 PM, Stefan Derkits <<a href="mailto:stefan@derkits.at" target="_blank">stefan@derkits.at</a>> wrote:<br>
>>><br>
>>> -----BEGIN PGP SIGNED MESSAGE-----<br>
>>> Hash: SHA1<br>
>>><br>
>>> Hi,<br>
>>><br>
>>> On 04/27/2013 11:45 AM, Vedant Agarwala wrote:<br>
>>> > I agree. I will upload another patch making changes to both <a href="http://last.fm" target="_blank">last.fm</a><br>
>>> > and magnatune code. I was thinking of a common helper class<br>
>>> > complete with the "no KWallet found dialog". Tell me any other<br>
>>> > specifics that should be a part of this KWalletHelper class.<br>
>>><br>
>>> a common KWallet Helper Class (if possible) sounds good, the<br>
>>> GpodderService uses KWallet code that at the time of the creation of<br>
>>> the code was more or less a copy of the <a href="http://last.fm" target="_blank">last.fm</a> Wallet Code. So maybe<br>
>>> the GpodderService could also be a Candidate for using this<br>
>>> KWalletHelper class ;)<br>
>>><br>
>>> Greetings,<br>
>>> Stefan<br>
>>> -----BEGIN PGP SIGNATURE-----<br>
>>> Version: GnuPG v1.4.12 (GNU/Linux)<br>
>>><br>
>>> iEYEARECAAYFAlF7pssACgkQlZvAMV/NgGLEkQCgoai1Bi/PzZ4H6P1iNPQ4q42X<br>
>>> b3wAn1SsfeE/9ipouiiVLBtNFB9WDzUg<br>
>>> =5o1m<br>
>>> -----END PGP SIGNATURE-----<br>
>><br>
>><br>
><br>
><br>
</div></div>> _______________________________________________<br>
> Amarok-devel mailing list<br>
> <a href="mailto:Amarok-devel@kde.org" target="_blank">Amarok-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
><br>
<br>
--<br>
Mark Kretschmann<br>
Amarok Developer<br>
Fellow of the Free Software Foundation Europe<br>
<a href="http://amarok.kde.org" target="_blank">http://amarok.kde.org</a> - <a href="http://fsfe.org" target="_blank">http://fsfe.org</a><br>
_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org" target="_blank">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>