<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Thank you for your tireless work! I
outlined the changes below. I'm not posting the whole proposal
this time since only two points were added in the text.<br>
<br>
On 29.04.2013 23:12, Matěj Laitl wrote<br>
</div>
<blockquote cite="mid:9700553.xAgr7ffyVr@edgy" type="cite">
<pre wrap="">
Some more things to iron out about StatSyncing::Amarok2Provider:
* would you support both a) connecting to a "live" database server and b)
opening the database stored in a folder yourself using mysql-embedded
* Amarok database schema changes sometimes with versions, it would be nice if
you could also sync against older versions (starting at least with let's say
with Amarok 2.5) and perhaps also with future versions (unless the schema
changes too much). You might do some fuzzy checks of the db schema before
syncing to ensure you're working with what you expect.
</pre>
</blockquote>
<br>
Right. I added following points to "Implement Rhythmbox and Amarok
2.x importers" subsection:<br>
<ul>
<li>Amarok 2.x importer should support importing data from both a
full mysql server and mysql-embedded file. To ensure that
metadata from current version of Amarok can always be
synchronized, Collections::SqlCollection class will be used
along with MySqlStorage and MySqlEmbeddedStorage classes.</li>
<li>As an optional goal, backwards compatibility for Amarok 2.x
importer will be provided down to version 2.5. A version
auto-detection based on database schema would be added for
convenience, with user being able to specify the version
explicitly.</li>
</ul>
<br>
I put backwards compatibility as an optional goal because it's
significantly more work to both implement and maintain it than
straight current-version provider. For current version, on the other
hand, I can simply use Collections::SqlCollection for the provider,
and it could even out-of-the-box work with
StatSyncing::CollectionProvider.<br>
<br>
<blockquote cite="mid:9700553.xAgr7ffyVr@edgy" type="cite">
<blockquote type="cite">
<pre wrap=""> Junior job link
[3] <#ref3>
</pre>
</blockquote>
<pre wrap="">
Also [4]?
</pre>
</blockquote>
<br>
Added.<br>
<br>
<blockquote cite="mid:9700553.xAgr7ffyVr@edgy" type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap=""> Images
[8] <a class="moz-txt-link-freetext" href="http://student.agh.edu.pl/~zemek/amarok/config_metadata_tab.png">http://student.agh.edu.pl/~zemek/amarok/config_metadata_tab.png</a>
</pre>
</blockquote>
<pre wrap="">
Nice, exactly as I imagined it. (nitpick: for better discoverability you might
rename "Add..." to "Sync with Amarok 1.4/2.x/Rhythmbox...")
</pre>
</blockquote>
<br>
I left it as "Add" for now, as it gives out my intent quite nicely.
There will be time later to come up with more fitting labels. One
problem that I have with "Sync with [stuff]" or "Add [stuff]
targets" it the length; I feel that labels should be both clear
(which "Add" isn't, though) and concise.<br>
<br>
<blockquote cite="mid:9700553.xAgr7ffyVr@edgy" type="cite">
<pre wrap=""><a class="moz-txt-link-freetext" href="http://student.agh.edu.pl/~zemek/amarok/add_rhythmbox_synchronization_target_dialog.png">http://student.agh.edu.pl/~zemek/amarok/add_rhythmbox_synchronization_target_dialog.png</a>
Well, "Match Tracks by Metadata" would be the only way to match them, wouldn't
it?</pre>
</blockquote>
<br>
...it actually would. That didn't make much sense. I guess I was
thinking too much about reflecting current capabilities (there's a
"match by metadata" checkbox for Amarok 1.4 importer) in the new
dialogs and got a bit ahead of myself. Changed that.<br>
<br>
<blockquote cite="mid:9700553.xAgr7ffyVr@edgy" type="cite">
<pre wrap="">
Matěj</pre>
</blockquote>
Konrad<br>
</body>
</html>