<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110139/">http://git.reviewboard.kde.org/r/110139/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 17f3e7a9cd2dbb201dfc580c8c1d40b4fec85922 by Matěj Laitl on behalf of Konrad Zemek to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 27th, 2013, 10:11 p.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated April 27, 2013, 10:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small bugfixes. Fixes clang warnings.
A few legitimate, non critical bugs. Also minor changes to explicitly cover all enums in switch statements.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed lines no longer generate warnings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/playlistbrowser/PlaylistBrowserView.cpp <span style="color: grey">(fc7fe14a10ae0f4b25f9b0e0ccb85c246b82313d)</span></li>
<li>src/core-impl/collections/daap/daapreader/authentication/md5.c <span style="color: grey">(089118ff8bcd20aecade257c31d56a0447fc04de)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: grey">(fc5f6df29d9e22a97712a31b2aa71bc0e6424b40)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(93e068124beae4ba4f294e476d696cc0196dd298)</span></li>
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110139/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>