<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110139/">http://git.reviewboard.kde.org/r/110139/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 24th, 2013, 12:47 p.m. UTC, <b>Myriam Schweingruber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Which exact bugs does that fix? are those reported on http://bugs.kde.org? Then please add the "BUG: <bugnumber>" handler and "FIXED-IN: 2.8" handler to it as well :)</pre>
</blockquote>
<p>On April 24th, 2013, 3:46 p.m. UTC, <b>Konrad Zemek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None of these bugs are reported in bugs.kde.org (at least I couldn't find any matching report).
In the order shown by reviewboard's diff, the bugs fixed are following:
1. Introduced with https://bugs.kde.org/show_bug.cgi?id=305203 : !state() == EditingState is always evaluating to false, so instead of stopping 'return' key from adding tracks to the playlist while in edit mode, this fix accidently stopped the key from adding tracks in all modes.
2. Obvious error when we're filling a struct with 0's, and instead of using the size of struct itself, we're using the size of pointer type.
3 & 4. When an integer (enum in this case) is added to "string", it is actually evaluated as if it was
const char *str = "string";
const char *result = str + value; // a.k.a. str[value];
That's surely not what we want to achieve here. By using QString::number, a QString is first constructed from the integer and then added to "string", so we get a valid string like we wanted.
5, 6 & 7. These are just to silence compiler warnings about not all enums being uses in a switch; in these switches we're providing cases for all relevant enum values, so default: break tells the compiler that we're sure nothing else should be handled.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Righto righto, I think the confusion came from the sentence "A few legitimate, non critical bugs" - which may suggest that the bugs were reported to bugs.kde.org.
We don't normally require to be elaborate about small cleanups & fixes that are obvious from the diff - don't fear. :-)</pre>
<br />
<p>- Matěj</p>
<br />
<p>On April 24th, 2013, 12:25 a.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated April 24, 2013, 12:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small bugfixes. Fixes clang warnings.
A few legitimate, non critical bugs. Other changes are adding default case for enum switches where we're sure that all relevant cases have been covered.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed lines no longer generate warnings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/playlistbrowser/PlaylistBrowserView.cpp <span style="color: grey">(fc7fe14a10ae0f4b25f9b0e0ccb85c246b82313d)</span></li>
<li>src/core-impl/collections/daap/daapreader/authentication/md5.c <span style="color: grey">(089118ff8bcd20aecade257c31d56a0447fc04de)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: grey">(fc5f6df29d9e22a97712a31b2aa71bc0e6424b40)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(93e068124beae4ba4f294e476d696cc0196dd298)</span></li>
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110139/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>