<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110082/">http://git.reviewboard.kde.org/r/110082/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I forgot to say thanks for the patch and from taking advice from our comments on another review! Looks good to me, although I've changed the title to make sure other devs realize that this is an important change and have a chance to speak.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On April 21st, 2013, 12:05 a.m. UTC, Vedant Agarwala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Vedant Agarwala.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 12:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As agreed on the review for https://git.reviewboard.kde.org/r/104048/ , Qt::TooltipRole has been updated so that now the tooltip displays full name of the playlist. Occurrences of "description" have been removed (from the Playlist base class as well as the subclasses).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done. Works. Builds successfully and passes the tests.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=275821">275821</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: grey">(2d6ef61)</span></li>
<li>src/playlistmanager/sql/SqlPlaylist.h <span style="color: grey">(d28d161)</span></li>
<li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: grey">(56be7e8)</span></li>
<li>src/playlistmanager/SyncedPlaylist.h <span style="color: grey">(214bb5c)</span></li>
<li>src/core/playlists/Playlist.h <span style="color: grey">(cf9a4c0)</span></li>
<li>src/core-impl/playlists/types/file/PlaylistFile.cpp <span style="color: grey">(073e140)</span></li>
<li>src/core-impl/playlists/types/file/PlaylistFile.h <span style="color: grey">(0358196)</span></li>
<li>src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.cpp <span style="color: grey">(3510481)</span></li>
<li>src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h <span style="color: grey">(9b94872)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: grey">(6ee3db3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110082/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot1.png">displays the new tooltip</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot.png">displays the new tooltip</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>