<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109781/">http://git.reviewboard.kde.org/r/109781/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>


<p style="color: grey;"><i>Updated April 19, 2013, 1:47 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All done</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  (updated)</h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added 3 checkbox in the TranscodingAssistantDialog:
"Transcode all tracks" - transcode all tracks, the current default behavior
"Ignore files which're already the selected format" - transcode only if source and destination file formats are different
"Transcode only when needed for playability" - transcode only when needed for playability in the destination collection</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected
All build tests passed</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ChangeLog <span style="color: grey">(cc8b166)</span></li>

 <li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(8bc4552)</span></li>

 <li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h <span style="color: grey">(3c2d9f2)</span></li>

 <li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp <span style="color: grey">(8a40c6c)</span></li>

 <li>src/core-impl/collections/support/CollectionLocationDelegateImpl.h <span style="color: grey">(b59beec)</span></li>

 <li>src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp <span style="color: grey">(f19cd9d)</span></li>

 <li>src/core-impl/collections/umscollection/UmsCollectionLocation.h <span style="color: grey">(45ba596)</span></li>

 <li>src/core-impl/collections/umscollection/UmsCollectionLocation.cpp <span style="color: grey">(2a30c9f)</span></li>

 <li>src/core/collections/CollectionLocation.cpp <span style="color: grey">(08f6910)</span></li>

 <li>src/core/collections/CollectionLocationDelegate.h <span style="color: grey">(6316d6f)</span></li>

 <li>src/core/transcoding/TranscodingConfiguration.h <span style="color: grey">(98b2bb8)</span></li>

 <li>src/core/transcoding/TranscodingConfiguration.cpp <span style="color: grey">(f97a43d)</span></li>

 <li>src/transcoding/TranscodingAssistantDialog.h <span style="color: grey">(76287a7)</span></li>

 <li>src/transcoding/TranscodingAssistantDialog.cpp <span style="color: grey">(8348b12)</span></li>

 <li>src/transcoding/TranscodingAssistantDialog.ui <span style="color: grey">(2505bd3)</span></li>

 <li>src/transcoding/TranscodingOptionsStackedWidget.h <span style="color: grey">(9495d44)</span></li>

 <li>src/transcoding/TranscodingOptionsStackedWidget.cpp <span style="color: grey">(cf4f328)</span></li>

 <li>src/transcoding/TranscodingSelectConfigWidget.h <span style="color: grey">(aa5f196)</span></li>

 <li>src/transcoding/TranscodingSelectConfigWidget.cpp <span style="color: grey">(adb593c)</span></li>

 <li>tests/core/collections/MockCollectionLocationDelegate.h <span style="color: grey">(5efbe2e7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109781/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png">TranscodingAssistantDialog</a></li>

</ul>





  </td>
 </tr>
</table>




  </div>
 </body>
</html>