<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109470/">http://git.reviewboard.kde.org/r/109470/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Adds the proper fix along with the not affecting cached lyrics stuff.
I don't see it.
> Should I removenthe cached lyrics completely?
Yes, please remove the unneeded changes to cached lyrics you introduced earlier.
Also please remove the unrelated and harmful changes to CMakeLists.txt - commenting-out macro_optional_find_package is obviously a bad idea!</pre>
<br />
<p>- Matěj</p>
<br />
<p>On April 4th, 2013, 11:37 p.m. UTC, mayank jha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By mayank jha.</div>
<p style="color: grey;"><i>Updated April 4, 2013, 11:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It required modifications, when there is no change in the lyrics downloaded and lyrics retrieved from cache the title display of the lyrics browser changes to "Cached Lyrics" from "Lyrics" so we can tell the difference between old and new. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Its working fine!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d167577)</span></li>
<li>src/context/applets/lyrics/LyricsApplet.cpp <span style="color: grey">(2394964)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.h <span style="color: grey">(b187b73)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: grey">(2befa91)</span></li>
<li>src/core-impl/collections/nepomukcollection/CMakeLists.txt <span style="color: grey">(642919b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109470/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>