<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109817/">http://git.reviewboard.kde.org/r/109817/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated April 8, 2013, 6:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Added notPlayableReason(0 and prettyNotPlayableReason() to Track
2. Display tooltip with the prettyNotPlayableReason if track not playable</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added two indicators for no-read permission:
1. A tooltip "No read permissions" for tracks with no read permissions
2. Upon right-clicking such a track, displays a "No read permissions" disabled action.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/audiocd/AudioCdMeta.h <span style="color: grey">(fc26fcc)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdMeta.cpp <span style="color: grey">(218ce2a)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.h <span style="color: grey">(9a9c257)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.cpp <span style="color: grey">(e66afb7)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.h <span style="color: grey">(b7f0a71)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(19ec936)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodMeta.h <span style="color: grey">(1d380b1)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodMeta.cpp <span style="color: grey">(9ffcf7e)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(5d1b9f9)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(2b66574)</span></li>
<li>src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h <span style="color: grey">(27ff06d)</span></li>
<li>src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp <span style="color: grey">(6d5bcf7)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.h <span style="color: grey">(7a39a4f)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.cpp <span style="color: grey">(5f4ec3c)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.h <span style="color: grey">(ef342a4)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(e58a20a)</span></li>
<li>src/core-impl/collections/support/MemoryMeta.h <span style="color: grey">(40061d2)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.h <span style="color: grey">(55bc131)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: grey">(00cc915)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(7d3359d)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(2cd0a61)</span></li>
<li>src/core-impl/meta/multi/MultiTrack.h <span style="color: grey">(be55170)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(15967df)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(6a35bc5)</span></li>
<li>src/core-impl/meta/stream/Stream.h <span style="color: grey">(3e19b45)</span></li>
<li>src/core-impl/meta/stream/Stream.cpp <span style="color: grey">(6e35960)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.h <span style="color: grey">(3aed4f9)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.cpp <span style="color: grey">(e3490e4)</span></li>
<li>src/core/meta/Meta.h <span style="color: grey">(f86cf39)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(f3b21de)</span></li>
<li>src/playlist/PlaylistModel.cpp <span style="color: grey">(246b9a1)</span></li>
<li>src/services/ServiceMetaBase.h <span style="color: grey">(f25159d)</span></li>
<li>src/services/ServiceMetaBase.cpp <span style="color: grey">(7537649)</span></li>
<li>src/services/ampache/AmpacheMeta.h <span style="color: grey">(934fe75)</span></li>
<li>src/services/ampache/AmpacheMeta.cpp <span style="color: grey">(b59715c)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.h <span style="color: grey">(9c54a10)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: grey">(424d136)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109817/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>