<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109846/">http://git.reviewboard.kde.org/r/109846/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Oliver Henshaw.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated April 6, 2013, 4:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options:
Pause playback on suspend
Inhibit suspend if playing
2. Created a PowerManager class to handle suspend behavior
Fixes:
BR 259862 - Amarok does not inhibit suspend while playing
BR 222571 - Amarok pause on suspend</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playback/PowerManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/configdialog/dialogs/PlaybackConfig.ui <span style="color: grey">(3a79e43)</span></li>
<li>src/amarokconfig.kcfg <span style="color: grey">(fbe5497)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(52bfd90)</span></li>
<li>ChangeLog <span style="color: grey">(3422cad)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(990f313)</span></li>
<li>src/playback/PowerManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core-impl/meta/multi/CMakeLists.txt <span style="color: grey">(327b555)</span></li>
<li>tests/playlist/CMakeLists.txt <span style="color: grey">(c2e4c06)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109846/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png">PlaybackConfig Dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>