<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109794/">http://git.reviewboard.kde.org/r/109794/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7a72f13d7f57e83efdae66b5078b7f1aa0131b2d by Matěj Laitl on behalf of Anmol Ahuja to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 2nd, 2013, 5:41 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated April 2, 2013, 5:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines
Used this script:
https://qt.gitorious.org/qt/qt/trees/v4.7.3/util/normalize
UPDATE: Ran normalize on new master, fixed whtespaces, tested
Uploading a patch generated using "git format-patch" too, it's more convenient to apply</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build tests passed
Everything seems to be working right
Patch applies cleanly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/tabs/TabsApplet.cpp <span style="color: grey">(531a257)</span></li>
<li>src/context/applets/songkick/SongkickApplet.cpp <span style="color: grey">(8d1b468)</span></li>
<li>src/context/applets/photos/PhotosScrollWidget.cpp <span style="color: grey">(555dfda)</span></li>
<li>src/context/applets/photos/PhotosApplet.cpp <span style="color: grey">(ed26f33)</span></li>
<li>src/context/applets/lyrics/LyricsApplet.cpp <span style="color: grey">(2394964)</span></li>
<li>src/context/applets/labels/LabelsApplet.cpp <span style="color: grey">(2df1173)</span></li>
<li>src/context/applets/info/InfoApplet.cpp <span style="color: grey">(8974519)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.cpp <span style="color: grey">(ff3bec7)</span></li>
<li>src/context/ToolbarView.cpp <span style="color: grey">(679f027)</span></li>
<li>src/context/ContextView.cpp <span style="color: grey">(e41638d)</span></li>
<li>src/context/ContextDock.cpp <span style="color: grey">(a445677)</span></li>
<li>src/context/Applet.cpp <span style="color: grey">(fd5abe9)</span></li>
<li>src/configdialog/dialogs/PlaybackConfig.cpp <span style="color: grey">(c4f357b)</span></li>
<li>src/configdialog/dialogs/NotificationsConfig.cpp <span style="color: grey">(d558325)</span></li>
<li>src/configdialog/dialogs/DatabaseConfig.cpp <span style="color: grey">(77ea254)</span></li>
<li>src/configdialog/dialogs/CollectionConfig.cpp <span style="color: grey">(5f546ac)</span></li>
<li>src/configdialog/ConfigDialog.cpp <span style="color: grey">(320e6ab)</span></li>
<li>src/browsers/servicebrowser/ServiceBrowser.cpp <span style="color: grey">(6f576a1)</span></li>
<li>src/browsers/playlistbrowser/QtGroupingProxy.cpp <span style="color: grey">(24f611c)</span></li>
<li>src/browsers/playlistbrowser/PodcastCategory.cpp <span style="color: grey">(4631d27)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp <span style="color: grey">(0ccaf93)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserView.cpp <span style="color: grey">(c885f7c)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: grey">(658af22)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserFilterProxy.cpp <span style="color: grey">(84439fa)</span></li>
<li>playground/src/context/applets/coverbling/CoverBling.cpp <span style="color: grey">(9401514)</span></li>
<li>playground/src/context/applets/coverbling/CoverBlingApplet.cpp <span style="color: grey">(5b355ba)</span></li>
<li>playground/src/context/applets/coverbling/PhotoBrowser.cpp <span style="color: grey">(856e9c2)</span></li>
<li>playground/src/context/applets/coverbling/pictureflow.cpp <span style="color: grey">(057e8d1)</span></li>
<li>playground/src/context/applets/covergrid/CoverGridApplet.cpp <span style="color: grey">(2432df6)</span></li>
<li>src/ActionClasses.cpp <span style="color: grey">(bb68c64)</span></li>
<li>src/AmarokMimeData.cpp <span style="color: grey">(edd4279)</span></li>
<li>src/AmarokProcess.cpp <span style="color: grey">(fc13307)</span></li>
<li>src/App.cpp <span style="color: grey">(416d4dc)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(58d7360)</span></li>
<li>src/LastfmReadLabelCapability.cpp <span style="color: grey">(f0929ea)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(da2e0f2)</span></li>
<li>src/MediaDeviceCache.cpp <span style="color: grey">(c9758cd)</span></li>
<li>src/MediaDeviceMonitor.cpp <span style="color: grey">(dd22114)</span></li>
<li>src/OpmlParser.cpp <span style="color: grey">(a935038)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(022a65f)</span></li>
<li>src/ScriptUpdater.cpp <span style="color: grey">(d1b1ccb)</span></li>
<li>src/SvgHandler.cpp <span style="color: grey">(4f5335b)</span></li>
<li>src/TrayIcon.cpp <span style="color: grey">(606b644)</span></li>
<li>src/aboutdialog/ExtendedAboutDialog.cpp <span style="color: grey">(eca67d9)</span></li>
<li>src/aboutdialog/OcsPersonItem.cpp <span style="color: grey">(1174c0b)</span></li>
<li>src/aboutdialog/OcsPersonListWidget.cpp <span style="color: grey">(1a4af3d)</span></li>
<li>src/aboutdialog/libattica-ocsclient/activitylistjob.cpp <span style="color: grey">(d8c4bef)</span></li>
<li>src/aboutdialog/libattica-ocsclient/categorylistjob.cpp <span style="color: grey">(cf8fadc)</span></li>
<li>src/aboutdialog/libattica-ocsclient/contentjob.cpp <span style="color: grey">(132fe36)</span></li>
<li>src/aboutdialog/libattica-ocsclient/contentlistjob.cpp <span style="color: grey">(c85d1ba)</span></li>
<li>src/aboutdialog/libattica-ocsclient/eventjob.cpp <span style="color: grey">(d458905)</span></li>
<li>src/aboutdialog/libattica-ocsclient/eventlistjob.cpp <span style="color: grey">(7cf59b7)</span></li>
<li>src/aboutdialog/libattica-ocsclient/folderlistjob.cpp <span style="color: grey">(de30a74)</span></li>
<li>src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp <span style="color: grey">(8558719)</span></li>
<li>src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp <span style="color: grey">(2dab20a)</span></li>
<li>src/aboutdialog/libattica-ocsclient/messagelistjob.cpp <span style="color: grey">(3f32a84f)</span></li>
<li>src/aboutdialog/libattica-ocsclient/personjob.cpp <span style="color: grey">(722f343)</span></li>
<li>src/aboutdialog/libattica-ocsclient/personlistjob.cpp <span style="color: grey">(6dc415b)</span></li>
<li>src/aboutdialog/libattica-ocsclient/postjob.cpp <span style="color: grey">(fd790ac)</span></li>
<li>src/amarokurls/AmarokUrlAction.cpp <span style="color: grey">(b04b7a4)</span></li>
<li>src/amarokurls/BookmarkCurrentButton.cpp <span style="color: grey">(d4b3a19)</span></li>
<li>src/amarokurls/BookmarkManagerWidget.cpp <span style="color: grey">(1806a6b)</span></li>
<li>src/amarokurls/BookmarkMetaActions.cpp <span style="color: grey">(9a11a94)</span></li>
<li>src/amarokurls/BookmarkTreeView.cpp <span style="color: grey">(7a033e0)</span></li>
<li>src/browsers/BrowserBreadcrumbItem.cpp <span style="color: grey">(ad485c6)</span></li>
<li>src/browsers/BrowserBreadcrumbWidget.cpp <span style="color: grey">(3b789c2)</span></li>
<li>src/browsers/BrowserCategoryList.cpp <span style="color: grey">(ad0079b)</span></li>
<li>src/browsers/BrowserDock.cpp <span style="color: grey">(dabe43d)</span></li>
<li>src/browsers/BrowserMessageArea.cpp <span style="color: grey">(dc36257)</span></li>
<li>src/browsers/CollectionTreeItem.cpp <span style="color: grey">(26cd253)</span></li>
<li>src/browsers/CollectionTreeItemModel.cpp <span style="color: grey">(fa194b1)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(30067a1)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: grey">(aac232a)</span></li>
<li>src/browsers/SingleCollectionTreeItemModel.cpp <span style="color: grey">(babfc64)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: grey">(81960b1)</span></li>
<li>src/browsers/filebrowser/FileBrowser.cpp <span style="color: grey">(167fd33)</span></li>
<li>src/browsers/filebrowser/FileView.cpp <span style="color: grey">(61b27ea)</span></li>
<li>src/browsers/playlistbrowser/APGCategory.cpp <span style="color: grey">(e2acb9a)</span></li>
<li>src/browsers/playlistbrowser/DynamicBiasWidgets.cpp <span style="color: grey">(092f27b)</span></li>
<li>src/browsers/playlistbrowser/DynamicCategory.cpp <span style="color: grey">(0e1a4af)</span></li>
<li>src/browsers/playlistbrowser/DynamicView.cpp <span style="color: grey">(58c82e4)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp <span style="color: grey">(3478f68)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(0e7a214)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp <span style="color: grey">(60a2356)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp <span style="color: grey">(e416107)</span></li>
<li>src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp <span style="color: grey">(ba38501)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollectionLocation.cpp <span style="color: grey">(e0ba0ac)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: grey">(296d78d)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: grey">(eece2f7)</span></li>
<li>src/core-impl/collections/support/FileCollectionLocation.cpp <span style="color: grey">(b215490)</span></li>
<li>src/core-impl/collections/support/CollectionManager.cpp <span style="color: grey">(2433ee2)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp <span style="color: grey">(486eec9)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(ca6c460)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollection.cpp <span style="color: grey">(36252fd)</span></li>
<li>src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp <span style="color: grey">(035fbde)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Controller.cpp <span style="color: grey">(186f33c)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp <span style="color: grey">(8676a17)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.cpp <span style="color: grey">(6d291fe)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp <span style="color: grey">(bc23ad4)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukCollection.cpp <span style="color: grey">(22ecda2)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp <span style="color: grey">(a8d9f52)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp <span style="color: grey">(c1b76f5)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp <span style="color: grey">(f60aff6)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.cpp <span style="color: grey">(bdc76c6)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollection.cpp <span style="color: grey">(fa7b6d6)</span></li>
<li>src/core-impl/collections/db/sql/SqlRegistry.cpp <span style="color: grey">(2165234)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(11fa33e)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollection.cpp <span style="color: grey">(d32d651)</span></li>
<li>src/core-impl/collections/db/MountPointManager.cpp <span style="color: grey">(757f5dd)</span></li>
<li>src/core-impl/collections/db/DatabaseCollection.cpp <span style="color: grey">(0d47b0f)</span></li>
<li>src/context/applets/tabs/TabsView.cpp <span style="color: grey">(a49b50d)</span></li>
<li>src/context/containments/verticallayout/VerticalAppletLayout.cpp <span style="color: grey">(a9c6db7)</span></li>
<li>src/context/containments/verticallayout/VerticalToolbarContainment.cpp <span style="color: grey">(8fa6f9b)</span></li>
<li>src/context/engines/current/CurrentEngine.cpp <span style="color: grey">(41c1a39)</span></li>
<li>src/context/engines/labels/LabelsEngine.cpp <span style="color: grey">(ba6d369)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: grey">(2befa91)</span></li>
<li>src/context/engines/photos/PhotosEngine.cpp <span style="color: grey">(85cca30)</span></li>
<li>src/context/engines/songkick/SongkickEngine.cpp <span style="color: grey">(b641735)</span></li>
<li>src/context/engines/tabs/TabsEngine.cpp <span style="color: grey">(98aa84d)</span></li>
<li>src/context/engines/upcomingevents/UpcomingEventsEngine.cpp <span style="color: grey">(689323c)</span></li>
<li>src/context/engines/wikipedia/WikipediaEngine.cpp <span style="color: grey">(e08940e)</span></li>
<li>src/context/popupdropper/libpud/PopupDropper.cpp <span style="color: grey">(1f902e8)</span></li>
<li>src/context/popupdropper/libpud/PopupDropperItem.cpp <span style="color: grey">(dc0c02f)</span></li>
<li>src/context/toolbar/AppletItemOverlay.cpp <span style="color: grey">(8198b73)</span></li>
<li>src/context/toolbar/AppletToolbar.cpp <span style="color: grey">(4c98774)</span></li>
<li>src/context/toolbar/AppletToolbarAddItem.cpp <span style="color: grey">(d04e376)</span></li>
<li>src/context/toolbar/AppletToolbarAppletItem.cpp <span style="color: grey">(b81f981)</span></li>
<li>src/context/toolbar/AppletToolbarConfigItem.cpp <span style="color: grey">(68ff75e)</span></li>
<li>src/context/widgets/ContainmentArrow.cpp <span style="color: grey">(efd6721)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.cpp <span style="color: grey">(c9a8356)</span></li>
<li>src/context/widgets/TextScrollingWidget.cpp <span style="color: grey">(5aa86b8)</span></li>
<li>src/context/widgets/TrackWidget.cpp <span style="color: grey">(86ac01d)</span></li>
<li>src/core-impl/capabilities/AlbumActionsCapability.cpp <span style="color: grey">(cca5952)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp <span style="color: grey">(be13551)</span></li>
<li>src/core-impl/collections/audiocd/FormatSelectionDialog.cpp <span style="color: grey">(7ae2563)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.cpp <span style="color: grey">(5d1bd9b)</span></li>
<li>src/core-impl/collections/daap/daapreader/Reader.cpp <span style="color: grey">(127cbf6)</span></li>
<li>src/core-impl/collections/daap/daapreader/authentication/contentfetcher.cpp <span style="color: grey">(8dba010)</span></li>
<li>src/playlist/ProgressiveSearchWidget.cpp <span style="color: grey">(f96b7bf)</span></li>
<li>src/playlist/PlaylistSortWidget.cpp <span style="color: grey">(7689bce)</span></li>
<li>src/playlist/PlaylistQueueEditor.cpp <span style="color: grey">(f647e37)</span></li>
<li>src/playlist/PlaylistInfoWidget.cpp <span style="color: grey">(8138cc4)</span></li>
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(aa972dc)</span></li>
<li>src/playlist/PlaylistController.cpp <span style="color: grey">(0e35d53)</span></li>
<li>src/playlist/PlaylistBreadcrumbItem.cpp <span style="color: grey">(f9df4f5)</span></li>
<li>src/playlist/PlaylistActions.cpp <span style="color: grey">(48804b7)</span></li>
<li>src/network/NetworkAccessViewer.cpp <span style="color: grey">(4ea3951)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: grey">(d7b2da2)</span></li>
<li>src/musicbrainz/MusicBrainzTags.cpp <span style="color: grey">(08d4fdf)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(724c04d)</span></li>
<li>src/mac/GrowlInterface.cpp <span style="color: grey">(cb553ed)</span></li>
<li>src/likeback/LikeBackDialog.cpp <span style="color: grey">(5d11f72)</span></li>
<li>src/likeback/LikeBackBar.cpp <span style="color: grey">(11e8776)</span></li>
<li>src/likeback/LikeBack.cpp <span style="color: grey">(a3e555b)</span></li>
<li>src/dynamic/biases/TagMatchBias.cpp <span style="color: grey">(5c3b621)</span></li>
<li>src/dynamic/biases/SearchQueryBias.cpp <span style="color: grey">(3388b27)</span></li>
<li>src/dynamic/biases/QuizPlayBias.cpp <span style="color: grey">(b04d2a7)</span></li>
<li>src/dynamic/biases/PartBias.cpp <span style="color: grey">(3930791)</span></li>
<li>src/dynamic/biases/EchoNestBias.cpp <span style="color: grey">(48a8e8e)</span></li>
<li>src/dynamic/biases/AlbumPlayBias.cpp <span style="color: grey">(82b7884)</span></li>
<li>src/dynamic/BiasedPlaylist.cpp <span style="color: grey">(24c1a81)</span></li>
<li>src/dynamic/BiasSolver.cpp <span style="color: grey">(36c0204)</span></li>
<li>src/dynamic/BiasFactory.cpp <span style="color: grey">(b37d6da)</span></li>
<li>src/dynamic/Bias.cpp <span style="color: grey">(b1f7ede)</span></li>
<li>src/dialogs/transferdialog.cpp <span style="color: grey">(5b28459)</span></li>
<li>src/dialogs/deviceconfiguredialog.cpp <span style="color: grey">(bd95ff8)</span></li>
<li>src/dialogs/TagGuesserDialog.cpp <span style="color: grey">(6357f59)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(41477f2)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: grey">(0cf02b8)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: grey">(e831ddc)</span></li>
<li>src/dialogs/EqualizerDialog.cpp <span style="color: grey">(7d62e10)</span></li>
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(3e930cf)</span></li>
<li>src/dialogs/DatabaseImporterDialog.cpp <span style="color: grey">(596d6c1)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(d11a274)</span></li>
<li>src/dbus/mpris2/MediaPlayer2Player.cpp <span style="color: grey">(214b87d)</span></li>
<li>src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp <span style="color: grey">(60856c1)</span></li>
<li>src/dbus/mpris1/TrackListHandler.cpp <span style="color: grey">(5b3b0f7)</span></li>
<li>src/dbus/mpris1/PlayerHandler.cpp <span style="color: grey">(c2d1139)</span></li>
<li>src/dbus/DBusQueryHelper.cpp <span style="color: grey">(c7cdbfb)</span></li>
<li>src/databaseimporter/itunes/ITunesImporter.cpp <span style="color: grey">(2148d0e)</span></li>
<li>src/databaseimporter/amarok14/FastForwardWorker.cpp <span style="color: grey">(0988c19)</span></li>
<li>src/databaseimporter/amarok14/FastForwardImporterConfig.cpp <span style="color: grey">(dff4d14)</span></li>
<li>src/databaseimporter/amarok14/FastForwardImporter.cpp <span style="color: grey">(ce5e069)</span></li>
<li>src/databaseimporter/DatabaseImporter.cpp <span style="color: grey">(86e6e13)</span></li>
<li>src/covermanager/CoverManager.cpp <span style="color: grey">(ae516b2)</span></li>
<li>src/covermanager/CoverFoundDialog.cpp <span style="color: grey">(7a9d511)</span></li>
<li>src/covermanager/CoverFetcher.cpp <span style="color: grey">(1ce5c2d)</span></li>
<li>src/core/transcoding/TranscodingController.cpp <span style="color: grey">(6cf7e76)</span></li>
<li>src/core/podcasts/PodcastReader.cpp <span style="color: grey">(a801e88)</span></li>
<li>src/core/podcasts/PodcastImageFetcher.cpp <span style="color: grey">(139d4cd)</span></li>
<li>src/core/collections/support/TrackForUrlWorker.cpp <span style="color: grey">(864d91a)</span></li>
<li>src/core/collections/QueryMaker.cpp <span style="color: grey">(877840f)</span></li>
<li>src/core/collections/MetaQueryMaker.cpp <span style="color: grey">(0b7a2dd)</span></li>
<li>src/core/collections/CollectionLocation.cpp <span style="color: grey">(aecc068)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(7b24850)</span></li>
<li>src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp <span style="color: grey">(f7a109f)</span></li>
<li>src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp <span style="color: grey">(ac646aa)</span></li>
<li>src/core-impl/meta/timecode/TimecodeObserver.cpp <span style="color: grey">(ad8b811)</span></li>
<li>src/core-impl/logger/ProxyLogger.cpp <span style="color: grey">(143dedc)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp <span style="color: grey">(a76fc0d)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpSearchCollection.cpp <span style="color: grey">(a37f1d7)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceCollection.cpp <span style="color: grey">(82a92a5)</span></li>
<li>src/services/mp3tunes/Mp3tunesService.cpp <span style="color: grey">(4ab0805)</span></li>
<li>src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp <span style="color: grey">(d3323ac)</span></li>
<li>src/services/magnatune/MagnatuneXmlParser.cpp <span style="color: grey">(1bcfb98)</span></li>
<li>src/services/magnatune/MagnatuneStore.cpp <span style="color: grey">(7b611c0)</span></li>
<li>src/services/magnatune/MagnatuneSettingsModule.cpp <span style="color: grey">(444b8f9)</span></li>
<li>src/services/magnatune/MagnatuneRedownloadHandler.cpp <span style="color: grey">(6636214)</span></li>
<li>src/services/magnatune/MagnatuneInfoParser.cpp <span style="color: grey">(752afcd)</span></li>
<li>src/services/magnatune/MagnatuneDownloadHandler.cpp <span style="color: grey">(1b5ba3b)</span></li>
<li>src/services/magnatune/MagnatuneDatabaseWorker.cpp <span style="color: grey">(e21dced)</span></li>
<li>src/services/magnatune/MagnatuneAlbumDownloader.cpp <span style="color: grey">(7f52af1)</span></li>
<li>src/services/magnatune/MagnatuneActions.cpp <span style="color: grey">(15f49d5)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: grey">(4d29358)</span></li>
<li>src/services/lastfm/biases/WeeklyTopBias.cpp <span style="color: grey">(3f1a12d)</span></li>
<li>src/services/lastfm/biases/LastFmBias.cpp <span style="color: grey">(01401d8)</span></li>
<li>src/services/lastfm/SimilarArtistsAction.cpp <span style="color: grey">(0c4001f)</span></li>
<li>src/services/lastfm/LoveTrackAction.cpp <span style="color: grey">(1cd06d5)</span></li>
<li>src/services/lastfm/LastFmTreeView.cpp <span style="color: grey">(30f7d69)</span></li>
<li>src/services/lastfm/LastFmTreeModel.cpp <span style="color: grey">(54326a6)</span></li>
<li>src/services/lastfm/LastFmServiceSettings.cpp <span style="color: grey">(9ac218b)</span></li>
<li>src/services/lastfm/LastFmServiceCollection.cpp <span style="color: grey">(774b58f)</span></li>
<li>src/services/lastfm/LastFmService.cpp <span style="color: grey">(0612108)</span></li>
<li>src/services/jamendo/JamendoXmlParser.cpp <span style="color: grey">(7d09bd8)</span></li>
<li>src/services/jamendo/JamendoService.cpp <span style="color: grey">(33d82eb)</span></li>
<li>src/services/jamendo/JamendoMeta.cpp <span style="color: grey">(2068163)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: grey">(6988c78)</span></li>
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: grey">(6d63337)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(fca9bf3)</span></li>
<li>src/services/gpodder/GpodderProvider.cpp <span style="color: grey">(1bc6e2e)</span></li>
<li>src/services/ampache/LastfmInfoParser.cpp <span style="color: grey">(739b1f2)</span></li>
<li>src/services/ampache/AmpacheSettings.cpp <span style="color: grey">(ace3fec)</span></li>
<li>src/services/ampache/AmpacheService.cpp <span style="color: grey">(e3b9a40)</span></li>
<li>src/services/ampache/AddServerDialog.cpp <span style="color: grey">(a796b1d)</span></li>
<li>src/services/amazon/AmazonStore.cpp <span style="color: grey">(c41c7f8)</span></li>
<li>src/services/amazon/AmazonShoppingCartView.cpp <span style="color: grey">(c1fc593)</span></li>
<li>src/services/amazon/AmazonShoppingCartDialog.cpp <span style="color: grey">(905f0e5)</span></li>
<li>src/services/amazon/AmazonSettingsModule.cpp <span style="color: grey">(369e036)</span></li>
<li>src/services/amazon/AmazonItemTreeView.cpp <span style="color: grey">(a6d7db0)</span></li>
<li>src/services/amazon/AmazonItemTreeModel.cpp <span style="color: grey">(dbcf265)</span></li>
<li>src/services/amazon/AmazonInfoParser.cpp <span style="color: grey">(806a4fb)</span></li>
<li>src/services/ServiceSqlRegistry.cpp <span style="color: grey">(7dd073b)</span></li>
<li>src/services/ServiceSqlQueryMaker.cpp <span style="color: grey">(77efa2a)</span></li>
<li>src/services/ServiceBase.cpp <span style="color: grey">(d356962)</span></li>
<li>src/services/ServiceAlbumCoverDownloader.cpp <span style="color: grey">(763844f)</span></li>
<li>src/scriptengine/AmarokScriptableServiceScript.cpp <span style="color: grey">(77f580c)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.cpp <span style="color: grey">(1d38d4a)</span></li>
<li>src/scriptengine/AmarokNetworkScript.cpp <span style="color: grey">(57b46c4)</span></li>
<li>src/scriptengine/AmarokLyricsScript.cpp <span style="color: grey">(eb43a02)</span></li>
<li>src/scriptengine/AmarokEngineScript.cpp <span style="color: grey">(9d9906d)</span></li>
<li>src/scriptengine/AmarokCollectionScript.cpp <span style="color: grey">(6bd14ce)</span></li>
<li>src/scanner/GenericScannerJob.cpp <span style="color: grey">(2d58550)</span></li>
<li>src/scanner/GenericScanManager.cpp <span style="color: grey">(2ba7913)</span></li>
<li>src/scanner/AbstractScanResultProcessor.cpp <span style="color: grey">(3ffccf6)</span></li>
<li>src/scanner/AbstractDirectoryWatcher.cpp <span style="color: grey">(335b84e)</span></li>
<li>src/playlistmanager/PlaylistManager.cpp <span style="color: grey">(8cb2a76)</span></li>
<li>src/playlistgenerator/constraints/TagMatch.cpp <span style="color: grey">(f6a8ee0)</span></li>
<li>src/playlistgenerator/constraints/PreventDuplicates.cpp <span style="color: grey">(27de42a)</span></li>
<li>src/playlistgenerator/constraints/PlaylistLength.cpp <span style="color: grey">(e425c30)</span></li>
<li>src/playlistgenerator/constraints/PlaylistFileSize.cpp <span style="color: grey">(0429483)</span></li>
<li>src/playlistgenerator/constraints/PlaylistDuration.cpp <span style="color: grey">(b72c635)</span></li>
<li>src/playlistgenerator/constraints/Checkpoint.cpp <span style="color: grey">(c76683f)</span></li>
<li>src/playlistgenerator/TreeModel.cpp <span style="color: grey">(4ddd4d1)</span></li>
<li>src/playlistgenerator/PresetModel.cpp <span style="color: grey">(161d60e)</span></li>
<li>src/playlistgenerator/PresetEditDialog.cpp <span style="color: grey">(6f20547)</span></li>
<li>src/playlistgenerator/Preset.cpp <span style="color: grey">(6e6c30a)</span></li>
<li>src/playlistgenerator/ConstraintSolver.cpp <span style="color: grey">(cf7f8b7)</span></li>
<li>src/playlistgenerator/ConstraintGroup.cpp <span style="color: grey">(e5756a4)</span></li>
<li>src/playlist/view/listview/SourceSelectionPopup.cpp <span style="color: grey">(4499090)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: grey">(635448d)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: grey">(7dae262)</span></li>
<li>src/playlist/view/listview/InlineEditorWidget.cpp <span style="color: grey">(d7c02c5)</span></li>
<li>src/playlist/proxymodels/ProxyBase.cpp <span style="color: grey">(250e1e4)</span></li>
<li>src/playlist/proxymodels/GroupingProxy.cpp <span style="color: grey">(ad0fe92)</span></li>
<li>src/playlist/navigators/TrackNavigator.cpp <span style="color: grey">(85ddfa0)</span></li>
<li>src/playlist/navigators/RepeatTrackNavigator.cpp <span style="color: grey">(0c47783)</span></li>
<li>src/playlist/navigators/NonlinearTrackNavigator.cpp <span style="color: grey">(6a61bc0)</span></li>
<li>src/playlist/navigators/NavigatorConfigAction.cpp <span style="color: grey">(7bfc621)</span></li>
<li>src/playlist/navigators/DynamicTrackNavigator.cpp <span style="color: grey">(ad17335)</span></li>
<li>src/playlist/layouts/PlaylistLayoutEditDialog.cpp <span style="color: grey">(8c77e7d)</span></li>
<li>src/playlist/layouts/LayoutEditWidget.cpp <span style="color: grey">(faebbfb)</span></li>
<li>src/playlist/layouts/LayoutEditDialog.cpp <span style="color: grey">(44f778f)</span></li>
<li>src/playlist/layouts/LayoutConfigAction.cpp <span style="color: grey">(90b4585)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp <span style="color: grey">(aa61072)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp <span style="color: grey">(00a41d0)</span></li>
<li>src/services/mp3tunes/Mp3tunesSettingsModule.cpp <span style="color: grey">(0905401)</span></li>
<li>src/services/mp3tunes/Mp3tunesWorkers.cpp <span style="color: grey">(e4ae066)</span></li>
<li>src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp <span style="color: grey">(4c6c995)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryInfoParser.cpp <span style="color: grey">(a40ec10)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryModel.cpp <span style="color: grey">(ae93e66)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryService.cpp <span style="color: grey">(44ba847)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: grey">(856f570)</span></li>
<li>src/statusbar/CompoundProgressBar.cpp <span style="color: grey">(77941dc)</span></li>
<li>src/statusbar/KJobProgressBar.cpp <span style="color: grey">(3be03a0)</span></li>
<li>src/statusbar/LongMessageWidget.cpp <span style="color: grey">(0ee5a2b)</span></li>
<li>src/statusbar/ProgressBar.cpp <span style="color: grey">(f74a9fe)</span></li>
<li>src/synchronization/SynchronizationBaseJob.cpp <span style="color: grey">(f556032)</span></li>
<li>src/toolbar/CurrentTrackToolbar.cpp <span style="color: grey">(086419b)</span></li>
<li>src/toolbar/MainToolbar.cpp <span style="color: grey">(73438ed)</span></li>
<li>src/toolbar/VolumePopupButton.cpp <span style="color: grey">(2385a7d)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.cpp <span style="color: grey">(6bba0ec)</span></li>
<li>src/transcoding/TranscodingJob.cpp <span style="color: grey">(cab76a7)</span></li>
<li>src/transcoding/TranscodingPropertySliderWidget.cpp <span style="color: grey">(51aed8c)</span></li>
<li>src/widgets/AmarokDockWidget.cpp <span style="color: grey">(32ffded)</span></li>
<li>src/widgets/AnimatedLabelStack.cpp <span style="color: grey">(feff581)</span></li>
<li>src/widgets/BookmarkPopup.cpp <span style="color: grey">(a0187b0)</span></li>
<li>src/widgets/BreadcrumbItemButton.cpp <span style="color: grey">(861785e)</span></li>
<li>src/widgets/FilenameLayoutWidget.cpp <span style="color: grey">(7e40684)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(2e89418)</span></li>
<li>src/widgets/Osd.cpp <span style="color: grey">(93a08b6)</span></li>
<li>src/widgets/PlayPauseButton.cpp <span style="color: grey">(571dbb1)</span></li>
<li>src/widgets/PrettyTreeView.cpp <span style="color: grey">(d047eb8)</span></li>
<li>src/widgets/ProgressWidget.cpp <span style="color: grey">(6cd2fe1)</span></li>
<li>src/widgets/SearchWidget.cpp <span style="color: grey">(afa4e7b)</span></li>
<li>src/widgets/SliderWidget.cpp <span style="color: grey">(beecb9e)</span></li>
<li>src/widgets/SmartPlaylistEditor.cpp <span style="color: grey">(31bbedb)</span></li>
<li>src/widgets/TokenWithLayout.cpp <span style="color: grey">(50a17e7)</span></li>
<li>src/widgets/TrackActionButton.cpp <span style="color: grey">(d8d3a9a)</span></li>
<li>src/widgets/TrackSelectWidget.cpp <span style="color: grey">(5106219)</span></li>
<li>src/widgets/VolumeDial.cpp <span style="color: grey">(4447921)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp <span style="color: grey">(6e02116)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlScanManager.cpp <span style="color: grey">(3f1d010)</span></li>
<li>tests/core/collections/CollectionLocationTest.cpp <span style="color: grey">(e81a4ac)</span></li>
<li>tests/core/collections/TestQueryMaker.cpp <span style="color: grey">(47abe05)</span></li>
<li>tests/core/collections/support/TestTrackForUrlWorker.cpp <span style="color: grey">(6444434)</span></li>
<li>tests/dynamic/TestDynamicModel.cpp <span style="color: grey">(792f7cf)</span></li>
<li>tests/qt-modeltest/modeltest.cpp <span style="color: grey">(40d7d28)</span></li>
<li>tests/scanner/TestGenericScanManager.cpp <span style="color: grey">(57ecf95)</span></li>
<li>utilities/amzdownloader/AmzDownloader.cpp <span style="color: grey">(f476919)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: grey">(c051ed2)</span></li>
<li>utilities/updatesigner/signer.cpp <span style="color: grey">(99d315f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109794/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/fixSpacingGitformat2.patch">fixSpacingGitformat2.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>