<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109695/">http://git.reviewboard.kde.org/r/109695/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b0c79900429e8987c018112f875e09e565126408 by Matěj Laitl on behalf of Anmol Ahuja to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 27th, 2013, 6:21 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated March 27, 2013, 6:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug 241066 - JJ: Add Signals trackStop and amarokShutdown to Amarok scripting interface
Changes:
1. Added a prepareToQuit() signal to amarokWindowScript
2. Replaced kapp macro calls with App::instance() because quit() is not virtual
Note:
Signal trackFinished()[trackStop] already exists, so only added prepareToQuit()[amarokShutdown]</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the new signal in a script</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scriptengine/AmarokScript.cpp <span style="color: grey">(922e71d)</span></li>
<li>src/dbus/mpris2/MediaPlayer2.cpp <span style="color: grey">(f86ccb3)</span></li>
<li>src/scriptengine/AmarokWindowScript.h <span style="color: grey">(5407579)</span></li>
<li>src/dbus/mpris1/RootHandler.cpp <span style="color: grey">(e60eb1b)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(66f4f76)</span></li>
<li>ChangeLog <span style="color: grey">(284f188)</span></li>
<li>src/App.cpp <span style="color: grey">(fdb4255)</span></li>
<li>src/scriptengine/AmarokWindowScript.cpp <span style="color: grey">(897e2da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109695/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>