<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109224/">http://git.reviewboard.kde.org/r/109224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2013, 7:36 a.m. UTC, <b>Mark Kretschmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please don't apply this patch. Here's why:
Amarok is really not supposed to be running more than one instance at the same time (it's a "KUniqueApplication"). If you try to start another instance, you should be getting this message:
mark@serenity:~$ amarok
Amarok is already running!
Any command line flags will be processed by the already running instance. This is how the "%U" works.
Exception: If you run Amarok with the -m or --multipleinstances flag, it will happily start another instance.
</pre>
</blockquote>
<p>On March 6th, 2013, 11:33 a.m. UTC, <b>Fabian Kosmale</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First: I'm not sure if I'm misunderstanding you, but the linked bug is not about starting a new instance of Amarok, but giving focus to the already existing one when it's running in the background.
Also, are you sure about the command line flags (Mat?j, that also answers your question about %u versus %U )? fdo says: "%U: A list of URLs. Each URL is passed as a separate argument to the executable program. Local files may either be passed as file: URLs or as file path." and for "%u": "A single URL. Local files may either be passed as file: URLs or as file path." So as far as I understand the standard, command line flags (like -a) will never be passed to amarok, as they are not URLs (that does of course only apply iff Amarok is started via the desktop file). Furthermore, the only difference between "%u" and "%U" should be the number of URLs passed at the same time.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well my biggest concern is whether this breaks "Click on mp3 file in Dolphin to have it open in Amarok" and it is still unanswered.
Also, when %u means a single url, %U means multiple ones, omitting there altogether means no urls? That's certainly not what we want.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On March 5th, 2013, 5:02 p.m. UTC, Harikrishnan S. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Harikrishnan S..</div>
<p style="color: grey;"><i>Updated March 5, 2013, 5:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Resolved 315932, removed %U from amarok.desktop</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to be working. On launching the second time, the window does come up now. Also build perfectly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarok.desktop <span style="color: grey">(4fe72c0d96111f2bd8bdea3e12622e09320ad31c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109224/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>