<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103999/">http://git.reviewboard.kde.org/r/103999/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 5th, 2012, 6:19 a.m. UTC, <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would like to see the code you are working on that has a need for this change. I still think that it should go directly in core.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ryan, we are very sorry for any wasted efforts that could have been caused by past Amarok developers telling you to develop in playground while newe ones telling you this should go into core. We are still definitely interested in seeing the Equalizer scripting code. (I'm going to close this review request, it's just lying around, feel engouraged to submit a new one)</pre>
<br />
<p>- Matěj</p>
<br />
<p>On August 19th, 2012, 10:09 p.m. UTC, Ryan McCoskrie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ryan McCoskrie.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 10:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is infrastructure for future patches of mine (specifically equalizer scripting now that I am back on it).
The intention of this patch is to allow for the /playground directory to compile code directly into the
Amarok binary. The benefit this has to the Amarok project is that stable releases can include some experimental
featues that power users can opt into using.
Changes made to this patch:
0 Separated from a minor clean up of the playground
0 Separated from my equalizer scripting code (How on Earth did I overlook that?)
0 Added a brief tutorial on compiling in playground code
0 Now address all platforms, not just those using X11
0 Now intended for serious consideration of shipping.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked that the code compiles with the playground option enabled.
Since there is no active code, this should be sufficiant.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ebb8064)</span></li>
<li>playground/PLAYER_BINARY.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>playground/src/CMakeLists.txt <span style="color: grey">(ed740ec)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(8596144)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103999/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>