<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108907/">http://git.reviewboard.kde.org/r/108907/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 26th, 2013, 12:50 p.m. CET, <b>Martin Brodbeck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On February 26th, 2013, 12:54 p.m. CET, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Stupid me, there's never a faultless patch from me. :-/
No faultless patch was ever posted to reviewboard, at least not when I'm the reviewer. :-) And these were just nitpicks.
P.S.: the "Ship it!" button should be considered reserved to actual active Amarok developers.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. Would be great if the patch could make it into amarok 2.8.
Thanks, Matej!</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 26th, 2013, 8:08 a.m. CET, Martin Brodbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Matěj Laitl.</div>
<div>By Martin Brodbeck.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2013, 8:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In addition to request #108542, this patch adds opus transcoding.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(ddc9296)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(2809dc3)</span></li>
<li>src/core/transcoding/TranscodingConfiguration.cpp <span style="color: grey">(f1de929)</span></li>
<li>src/core/transcoding/TranscodingController.cpp <span style="color: grey">(265d1f8)</span></li>
<li>src/core/transcoding/TranscodingDefines.h <span style="color: grey">(8c68f15)</span></li>
<li>src/core/transcoding/formats/TranscodingOpusFormat.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/transcoding/formats/TranscodingOpusFormat.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>