<div dir="ltr">The short backward seek shortcut ( Control + Left) conflicts with the default Previous Browser shortcut. Should I change mine to Alt + L/ R? <div><br></div><div style>Mamarok said you don't use WhatsThis text in KDE anymore, so should the shortcut descriptions just go in the handbook?</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Feb 16, 2013 at 5:57 PM, Darth Codus <span dir="ltr"><<a href="mailto:darthcodus@gmail.com" target="_blank">darthcodus@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">So all I need to do is add a description of the shortcut keys to the whatsthis text?<div><p>Does the following sound okay:</p>
<p></p><pre style="white-space:pre-wrap;font-size:8pt;line-height:14.545454025268555px;margin-top:0px;margin-bottom:0px"><pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px">The length of a short seek <span style="font-size:8pt;font-family:arial">(Control + Left/ Right)</span><span style="font-size:8pt;font-family:arial">, in seconds.</span></pre>
<pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px">The length of a medium seek <span style="font-size:8pt;font-family:arial">(Left/ Right)</span><span style="font-size:8pt;font-family:arial">, in seconds.</span></pre>
<pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px">The length of a long seek <span style="font-size:8pt;font-family:arial">(Shift + Left/ Right)</span><span style="font-size:8pt;font-family:arial">, in seconds.</span></pre>
<pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px"><span style="font-family:arial;font-size:small;line-height:normal"><br></span></pre><pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px">
<span style="font-family:arial;font-size:small;line-height:normal">But these are just the defaults, they can be modified like any other shortcuts, so the whatsthis text might be a little misleading.</span></pre><pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px">
<span style="font-family:arial;font-size:small;line-height:normal"><br></span></pre><pre style="white-space:pre-wrap;font-size:8pt;margin-top:0px;margin-bottom:0px"><span style="font-family:arial;font-size:small;line-height:normal">---</span><br>
</pre></pre><p></p><p dir="ltr">Darth Codus</p></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Feb 16, 2013 at 3:56 PM, Ralf Engels <span dir="ltr"><<a href="mailto:ralf-engels@gmx.de" target="_blank">ralf-engels@gmx.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div>
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108964/" target="_blank">http://git.reviewboard.kde.org/r/108964/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Technically OK.
This whole seek options bloat up the code a little and the many options bloat the configuration but still on the good side in my opinion.
Can you add some text about the different keyboard modifiers. It's a little hard to figure out that there is even such a feature.
</pre>
<br>
<div>
<table width="100%" border="0" bgcolor="white">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/108964/diff/2/?file=114090#file114090line220" style="text-decoration:underline;font-weight:bold" target="_blank">src/configdialog/dialogs/PlaybackConfig.ui</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #c0c0c0" align="right"><font></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right"><font>220</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <string>The length of a medium seek, in seconds.</string></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Could you extend the whatsThis text to indicate what keyboard modificators you need to get a "short" "medium" and "long" seek.</pre>
</div>
<br>
<p>- Ralf</p><div>
<br>
<p>On February 15th, 2013, noon UTC, Anmol Ahuja wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color:grey"><i>Updated Feb. 15, 2013, noon</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
</div><table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Added 3 different seek options with customizable seek durations which can be set in the playback-config:
Control + L/R - Short seek
L/R - Normal/ Medium seek
Shift + L/R - Long seek
</pre>
</td>
</tr>
</tbody></table><div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/EngineController.h <span style="color:grey">(e9a8c26)</span></li>
<li>src/EngineController.cpp <span style="color:grey">(3577acf)</span></li>
<li>src/MainWindow.cpp <span style="color:grey">(8f985dc)</span></li>
<li>src/amarokconfig.kcfg <span style="color:grey">(3ebf71d)</span></li>
<li>src/configdialog/dialogs/PlaybackConfig.ui <span style="color:grey">(3a79e43)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108964/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>