<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108964/">http://git.reviewboard.kde.org/r/108964/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 15th, 2013, 10:13 a.m. UTC, <b>Edward Hades Toroshchin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not judging if this is needed at all, I see the following problems:
1. This removes the "Left" and "Right" shortcuts, which users may have gotten used to.
2. Usually (in games and photo editing software, for example) the precision modifiers are like this:
Ctrl-<key> — short seek (fine tuning)
<key> — default medium seek
Shift-<key> — long seek (fast scrolling, zooming, whatever).
I believe we should follow this "convention".</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1 to all of the above. This raises the question whether the default value (10s) of the mofidier-less seek (medium) should be kept at 10s or raised a bit.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On February 14th, 2013, 7:28 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2013, 7:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added 3 different seek options with customisable seek durations which can be set in the playback-config:
Shift + Left/Right= Short Seek
Alt + Left/Right= Medium Seek
Control + Left/Right= Long Seek
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EngineController.h <span style="color: grey">(e9a8c26)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(3577acf)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(8f985dc)</span></li>
<li>src/amarokconfig.kcfg <span style="color: grey">(3ebf71d)</span></li>
<li>src/configdialog/dialogs/PlaybackConfig.ui <span style="color: grey">(3a79e43)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108964/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>