<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108905/">http://git.reviewboard.kde.org/r/108905/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2013, 5:40 p.m. UTC, <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use a promoted widget instead. UI forms superior to this, we prefer to use them more, not less.
FYI the QueueEditor feature is not something we'll keep around for long. It's scheduled to be completely replaced one or two releases from now. Consider that before you spend days of useful coding time on it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://qt-project.org/doc/qt-4.8/designer-using-custom-widgets.html</pre>
<br />
<p>- Bart</p>
<br />
<p>On February 11th, 2013, 10:39 a.m. UTC, Bartosz Szreder wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Bartosz Szreder.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2013, 10:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the first patch (of two) resolving bug #263563
I need to create a specialized QListWidget implementation. Thus it seems easier to move the rather limited part of UI into the .cpp file and cleanly add another class with the desired modifications than to dig into .ui files with nonstandard classes.
This patch shouldn't introduce any changes in behavior yet. It's only purpose is to prepare ground for the next patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on two different instalations, no regressions noticed.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=263563">263563</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlist/PlaylistQueueEditor.h <span style="color: grey">(40b8cdf)</span></li>
<li>src/playlist/PlaylistQueueEditor.cpp <span style="color: grey">(f647e37)</span></li>
<li>src/playlist/PlaylistQueueEditor.ui <span style="color: grey">(a05cafd)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(043dc64)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108905/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>