<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106762/">http://git.reviewboard.kde.org/r/106762/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the status of this? Are you guys still working on it? Needs improvements? Can be commited? Should be discarded? It's been 4 months without activity!</pre>
<br />
<p>- Albert</p>
<br />
<p>On October 8th, 2012, 11:31 a.m. UTC, Mark Kretschmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Mark Kretschmann.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2012, 11:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactoring the Collection config UI code, by moving move more stuff into the UI file. Also, a resizing issue of the UI was fixed, as well as some other small issues.
There is one remaining issue with this patch:
The TreeView in the UI takes up too much vertical space, although the SizePolicy is set to Minimum. I can't figure out why it does that, so I'd welcome help.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested visual sanity of the UI, tested connections with config.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(9efeb20)</span></li>
<li>src/configdialog/dialogs/CollectionConfig.h <span style="color: grey">(02c80e1)</span></li>
<li>src/configdialog/dialogs/CollectionConfig.cpp <span style="color: grey">(42ffa1f)</span></li>
<li>src/configdialog/dialogs/CollectionConfig.ui <span style="color: grey">(692c3d9)</span></li>
<li>src/dialogs/CollectionSetup.h <span style="color: grey">(23d717a)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(5ae0294)</span></li>
<li>src/widgets/CollectionSetupTreeView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/widgets/CollectionSetupTreeView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106762/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>