<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107796/">http://git.reviewboard.kde.org/r/107796/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice work Riccardo, especially finding the right objects to delete in SVG files. However, the patch no longer applies to current git, please
1. (unless you have solved merge conflicts in git before) make backup: git branch master-backup master
2. git pull --rebase
3. solve trivial merge conflict (include got moved), solve my last nitpick (sorry about it, I wouldn't normally care that much, but since you're already updating..) and upload
Thanks!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107796/diff/5/?file=105474#file105474line352" style="color: black; font-weight: bold; text-decoration: underline;">src/playlist/view/listview/PrettyItemDelegate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Playlist::PrettyItemDelegate::paintItem( const LayoutItemConfig &config,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">348</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QRect</span> <span class="n">rect</span><span class="p">(</span> <span class="n">x</span><span class="p">,</span> <span class="n">y</span><span class="p">,</span> <span class="n">smallIconSize</span><span class="p">,</span> <span class="n">smallIconSize</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">352</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">int</span> <span class="n">iconWidth</span> <span class="o">=</span> <span class="n">smallIconSize</span> <span class="o">+</span> <span class="p">(</span> <span class="n">smallIconSize</span> <span class="o">/</span> <span class="mi">2</span> <span class="p">)</span> <span class="o">*</span> <span class="p">(</span> <span class="kt">int</span> <span class="p">)</span> <span class="n">log10</span><span class="p">(</span> <span class="n">queuePosition</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extreme nitpick:
we prefer constructor style casts int( float value ) for primitive types to C-style casts per http://qt-project.org/wiki/Coding-Conventions#32c00b11a9d4fa4bf1186733a599fc97 -> Casting</pre>
</div>
<br />
<p>- Matěj</p>
<br />
<p>On January 7th, 2013, 10:37 a.m., Riccardo Ferrazzo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Riccardo Ferrazzo.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 10:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've replaced the svg queue icon with a painted green rounded rectangle that scale based on the digits to display</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=253802">253802</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/images/default-theme-clean.svg <span style="color: grey">(6bad334)</span></li>
<li>src/images/default-theme.svg <span style="color: grey">(dbd3c90)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: grey">(c13542b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107796/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107796/s/918/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/18/snapshot1_400x100.png" style="border: 1px black solid;" alt="before" /></a>
<a href="http://git.reviewboard.kde.org/r/107796/s/919/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/18/screenshot7_400x100.png" style="border: 1px black solid;" alt="after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>