<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107193/">http://git.reviewboard.kde.org/r/107193/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, yes, we'll have to implement something like this to fix the problem. On the other hand, I'd like to implement it using a RAI principle as shown in https://git.reviewboard.kde.org/r/105995/ - that patch now just waits for phonon-vlc 0.6.1 to be released. When it is merged, equivalent fix could be applied using DelayedSeeker.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On November 4th, 2012, 10:08 a.m., Ben Cooksley wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ben Cooksley.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2012, 10:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This (for the most part) fixes the automatic seeking specified by CUE files as one changes tracks, with Phonon GStreamer at least.
It seems that GStreamer refuses to perform any form of seeking until the file has commenced playback, so we must initiate playback before we can seek.
Unfortunately, due to the async nature of Phonon::MediaObject->play() we must use the PlayingState signal to perform the seeking.
Not sure if this should be integrated due to that, or if there are better ways to refine it (maybe asking it to play and then immediately pausing it, seeking and then resuming playback - although that could cause a stutter instead). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested locally using Phonon GStreamer. CUE Files now cause tracks to be seeked to appropriately as Amarok moves between tracks.
There is a tiny amount (a few ms worth) which is played from the start of the track before the seeking kicks in unfortunately.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EngineController.cpp <span style="color: grey">(955e049)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>