<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106944/">http://git.reviewboard.kde.org/r/106944/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Edward Hades Toroshchin.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2012, 2:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note, that this is by far not a permanent solution! This merely changes the
collectionscanner behavior to "pass incorrect data to amarok" from the less
acceptable behavior "just error out and do nothing". This may result in some
unplayable tracks, but on the other hand, the collection scan will complete
successfully (more or less).
To fix this completely, we should either move to other serialization medium
(JSON?) or to another XML writer/reader. Thoughts, suggestions welcome.
collectionscanner: prevent writing malformed XML
As you probably know already, Qt deviates from the "output strictly,
input relaxed" practice by producing shit in QXmlStreamWriter, which is
then being rejected by QXmlStreamReader.
This is a temporary solution, to try to escape all possible occurences
of invalid characters in the XML.
UPDATE: since no one objects, let's just push this guy in.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Scanned own collection. Looks fine.
Scanned some folders with creepy characters. Looks also fine.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=305527">305527</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/collectionscanner/Directory.cpp <span style="color: grey">(46274ebc7fcbda9aa0123fd048ab3742f28dca64)</span></li>
<li>shared/collectionscanner/Playlist.cpp <span style="color: grey">(f131824b3461db21f7359479710b2c3164eb6149)</span></li>
<li>shared/collectionscanner/Track.h <span style="color: grey">(e691bb60da4f1a40dc98493630141d7ddb066383)</span></li>
<li>shared/collectionscanner/Track.cpp <span style="color: grey">(c08dbdaafe6ed85263d22701b58641a1eb76721d)</span></li>
<li>shared/collectionscanner/utils.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106944/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>