<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106431/">http://git.reviewboard.kde.org/r/106431/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. I didn't realize that it was separate from the regular debug. Less risk of it getting lost in the noise but might miss EngineController context. So I agree with matej's suggestion. Ship this one already though.</pre>
<br />
<p>- Bart</p>
<br />
<p>On September 12th, 2012, 11:35 a.m., Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2012, 11:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add new argument to activate audio (phonon) debugging
it simply injects the appropriate phonon 4.6+ environment variables in main.cpp
this is very helpful as 99% of all phonon bug reports get a first comment that asks the reporter to get an actual phonon relevant debug log, by making this simpler we can help reporters get relevant data quicker and since it is visually exposed they may even provide initial report logs with phonon debug active thus making bug triage twice as fast</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[x] start with --debug-audio
[x] start with --debug
[x] start with --debug --debug-audio
[x] start without any argument
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/App.cpp <span style="color: grey">(9b8bbe51e6fb93aef2e528b57ad3f5056f09c85a)</span></li>
<li>src/main.cpp <span style="color: grey">(4a48233ece598c90c6dd080473ec23a91ab2fe05)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106431/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>