<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101015/">http://git.reviewboard.kde.org/r/101015/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 28th, 2012, 2:15 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101015/diff/5/?file=81271#file81271line153" style="color: black; font-weight: bold; text-decoration: underline;">src/core/support/Amarok.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Amarok</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">153</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">i18nc</span><span class="p">(</span> <span class="s">"track was played within this day"</span><span class="p">,</span> <span class="s">"Today %1"</span><span class="p">,</span> <span class="n">datetime</span><span class="p">.</span><span class="n">toString</span><span class="p">(</span><span class="s">"hh:mm"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again i18n. The tricky thing with "hh:mm" is that not all countries use a leading zero for the hour. At least Qt is already handling 12/24 hour.
To circumvent the problem use Qt::TimeSpec again.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, but I actually have no idea. Should amarok.cpp provide serveral return-statments, depending on the country or is the kde architecture able to handle this with just make the time translatable by using something like:
i18nc( "track was played within this day", "Today %1", i18nc( "time in hh:mm", datetime.toString("hh:mm").toUtf8()));</pre>
<br />
<p>- Conrad</p>
<br />
<p>On August 26th, 2012, 5:28 p.m., Conrad Hübler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Conrad Hübler.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/support/Amarok.h <span style="color: grey">(d8c91e7)</span></li>
<li>src/core/support/Amarok.cpp <span style="color: grey">(7541124)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.h <span style="color: grey">(e023e91)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.cpp <span style="color: grey">(aa83a66)</span></li>
<li>src/context/applets/currenttrack/currentTrackSettings.ui <span style="color: grey">(c006384)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.h <span style="color: grey">(37032cb)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.cpp <span style="color: grey">(3b7bd72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101015/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>