<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101015/">http://git.reviewboard.kde.org/r/101015/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 17th, 2012, 12:31 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please have a look at the diff in reviewboard. Trailing spaces are hightlighted in red. Nobody likes them.
Also the basic issue is still open.
We have signals that get send whenever a track is played.
I can't understand why we need to have a timer to continuesly run to update recent played tracks.</pre>
</blockquote>
<p>On August 17th, 2012, 1:52 p.m., <b>Conrad Hübler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When amarok is idle for 20 minutes and the current track applet shows a title being played during the last minute, it might be confusing. All this is just do avoid this little design error.</pre>
</blockquote>
<p>On August 20th, 2012, 12:20 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok.
Then I was on the wrong track the whole time.
Then this makes a lot more sense.
Then my ownly complaints are missing comments (e.g. name the timer m_secondTimer; /** This timer is used to refresh the widget every second. This is needed so that recent played track times are update as the time progresses */)
And the trailing spaces.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I disagree. No application should timeout every second to just opdate the text "last played in last minute". This is a power consumtion problem on laptops, because every wakeup from deep power sleep causes signicifant draw of power. (re-entering the deepest power state could last several hundred of millisecods in more active CPU power states that consume much more energy)
Please do rework the text to show absolute time or use some kind of adaptive approach like "within a minute" -> "within an hour" -> "within a day" and ensure no extra timer timeouts are needed.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On July 30th, 2012, 8:17 p.m., Conrad Hübler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Conrad Hübler.</div>
<p style="color: grey;"><i>Updated July 30, 2012, 8:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/currenttrack/CurrentTrack.cpp <span style="color: grey">(aa83a66)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.h <span style="color: grey">(e023e91)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.h <span style="color: grey">(37032cb)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.cpp <span style="color: grey">(3b7bd72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101015/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>