<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106071/">http://git.reviewboard.kde.org/r/106071/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Edward Hades Toroshchin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">magnatune: first update related tweaks
These commits pursue single basic goal: not to let Magnatune service
plugin go ahead and download bunch of stuff from Magnatune at the first
Amarok run.
Basically, it's just a "allow auto updates" checkbox in the settings
(disabled by default), and a messge in Magnatune UI telling the user,
that she needs to let Amarok download Magnatune database manually, or
let Amarok download it automagically ever after.
magnatune: added "auto update database" option
magnatune: honor auto update settings
magnatune: ask user to update database
This adds a widget to the Magnatune service pane, that tells the user,
that Amarok needs to download Magnatune database, and that this can also
be performed automatically.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following correct behavior is observed:
1. First run:
a) Magnatune does not download the database automatically;
b) The "you need to download the database" widget appears.
2. After "update" button has been clicked:
a) Magnatune database is being downloaded;
b) The "you need to download the database" widget disappears.
3. Subsequent runs (after a successful update):
a) Magnatune just works;
b) If the "update automatically" checkbox is set, it checks for updates automatically.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/magnatune/CMakeLists.txt <span style="color: grey">(524b3e8cf3d45597cd91b5f0a181ebcc0878a229)</span></li>
<li>src/services/magnatune/MagnatuneConfig.h <span style="color: grey">(f1d25ebd3643086df4e09902a6b022a13765e810)</span></li>
<li>src/services/magnatune/MagnatuneConfig.cpp <span style="color: grey">(18ee8985b3cedbbf3559ef50a5a94643655d5269)</span></li>
<li>src/services/magnatune/MagnatuneConfigWidget.ui <span style="color: grey">(782ef25e153cee152ab4fbc35e1cd2de393bbe63)</span></li>
<li>src/services/magnatune/MagnatuneNeedUpdateWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/magnatune/MagnatuneNeedUpdateWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/magnatune/MagnatuneNeedUpdateWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/magnatune/MagnatuneSettingsModule.cpp <span style="color: grey">(3d7790b2c8d0719014695fa0ea04be5b929802dd)</span></li>
<li>src/services/magnatune/MagnatuneStore.h <span style="color: grey">(3f80e4c6e1cb350a14a3a157e76642ff48a96fcf)</span></li>
<li>src/services/magnatune/MagnatuneStore.cpp <span style="color: grey">(b1c5252f0d32bde21af6f39abcae485f8899162d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106071/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106071/s/680/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/18/2012-08-18-120330_1280x800_scrot_400x100.png" style="border: 1px black solid;" alt="the first-run widget" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>