<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102798/">http://git.reviewboard.kde.org/r/102798/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this still WIP?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102798/diff/2/?file=41439#file41439line367" style="color: black; font-weight: bold; text-decoration: underline;">src/ActionClasses.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">EqualizerAction::updateContent() //SLOT</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">367</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="o">!</span><span class="n">The</span><span class="o">::</span><span class="n">engineController</span><span class="p">()</span><span class="o">-></span><span class="n"><span class="hl">isE</span>qSupported</span><span class="p">()</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">367</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="o">!</span><span class="n">The</span><span class="o">::</span><span class="n">engineController</span><span class="p">()</span><span class="o">-></span><span class="n"><span class="hl">e</span>qSupported</span><span class="p">()</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The "isXxx" naming convention comes from Qt as you can get confusing names if you don't do that.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How do we continue? Is this ready to be submitted? What is the actual functionality? Can you also add a line for the ChangeLog.txt?</pre>
<p>- Ralf</p>
<br />
<p>On November 18th, 2011, 11:47 p.m., Ryan McCoskrie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ryan McCoskrie.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2011, 11:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the beginning of an effort to make a generic equalizer interface for plugins and scripts to access.
0: Gives the EngineController controller class new functions for examining, choosing and altering presets.
0: AmarokEngineScript provides functions to access the simpler equalizer functions in EngineController.
0: EqualizerDialog now uses the The::engineController() as a back end.
WARNING: I don't properly understand how the equalizer works. The largest changes in this patch are mostly
code moved from EqualizerDialog to EngineController. It's quite ugly in places.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">0: Briefly tested the Amarok.Engine.eqChangeCurrentPreset() function in the script console. Works as expected.
0: Amarok.Engine.eqBandsFreq() seems to return no value.
####################
# First Revision #
####################
0: Opened script console and Equalizer Dialog. Used both the dialog and Amarok.Engine.currentPreset property
to alter the equalizer. Everything appears to work properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ActionClasses.cpp <span style="color: grey">(5d87f4b)</span></li>
<li>src/EngineController.h <span style="color: grey">(3da2f23)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(6060137)</span></li>
<li>src/dialogs/EqualizerDialog.h <span style="color: grey">(9dad055)</span></li>
<li>src/dialogs/EqualizerDialog.cpp <span style="color: grey">(ddcd300)</span></li>
<li>src/scriptengine/AmarokEngineScript.h <span style="color: grey">(f1cdb8c)</span></li>
<li>src/scriptengine/AmarokEngineScript.cpp <span style="color: grey">(395c504)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102798/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>