<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100998/">http://git.reviewboard.kde.org/r/100998/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't see any problems with it but I would like somebody who is actually using podcasts to try this out before committing it.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On February 8th, 2012, 11:15 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2012, 11:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked.
These "kept" episodes are shown in the list regardless of the purgecount.
BUG Description:
Currently downloaded files are not kept when the episode is no longer shown in
the Podcast section. This behavior can not be configured but is tied to the
purge settings of each channel.
It's possible to add a "keep downloaded file" checkbox to episodes to prevent
the deletion from happening. We should perhaps also show these "kept" episodes
in the list regardless of the purgecount. So even if a channel has purgecount 5
and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes.
Reproducible: Always</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=261062">261062</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(18334f6)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(42ad039)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(1c3bdf4)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.h <span style="color: grey">(c3d5e56)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(183005f)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(679f7ac)</span></li>
<li>src/playlistmanager/SyncedPodcast.h <span style="color: grey">(c186df2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100998/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>