<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104369/">http://git.reviewboard.kde.org/r/104369/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't ship it.
Ratings will not longer be written back to the files. Search would not work (since the search is done in the sql database and the rating is not longer written there) and so on.
How about a real Nepumuk backed collection not using sql at all?
I would like to reject this request if you agree.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On March 22nd, 2012, 4:58 p.m., Phalgun Guduthur wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Teo Mrnjavac.</div>
<div>By Phalgun Guduthur.</div>
<p style="color: grey;"><i>Updated March 22, 2012, 4:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tried to demonstrate a basic read and write of Nepomuk index through Amarok by altering how song ratings are stored.
When applied, this patch stores any changed rating of a song into the Nepomuk index and not the Sql backend. To test this, change the rating of any song through Amarok and check the attributes of that song using Dolphin (song->properties). The song rating would have changed accordingly.
To demonstrate the read part, Each song's rating is fetched from the Nepomuk index instead of the Sql backend. To test this, change the rating of any song through Dolphin and the same would be reciprocated in Amarok.
Please note, this is only for proof of concept. This is not intended to be shipped.
The code changes I have made are only temporary. The actual project will have Nepomuk classes and handlers to do the same task. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The existing test cases work.
It has been tried on numerous songs successfully on my computer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/db/sql/CMakeLists.txt <span style="color: grey">(bdb3966)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(e663adf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104369/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>