<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102055/">http://git.reviewboard.kde.org/r/102055/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since we just released 2.6 I go though all the review requests.
I noticed that you done some re-formating and added "title", "genre", "tracknumber" and so on.
However those tags are already handled via the taglib title() and genre() function. They don't need special handling in our handlers.
So it seems that the "real" content of the patch is quite slim. It would be just some small format changes.
Also you didn't answer my question: Do the auto tests still run?
Please indicate what you want to do with the request.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On August 3rd, 2011, 9:20 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Ralf Engels.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2011, 9:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite if else else if Constructs to switch statements
Add common Frame Names to m_fieldMap</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compared output of collectionscanner before & after patch -> fixed some, but still some slight problems with TrackNo</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33)</span></li>
<li>shared/tag_helpers/TagHelper.h <span style="color: grey">(f8e7fd9fdad0ac3abd6efd34ad5e00c973233a6d)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(96f763e0839b59194484c1aa94cd266d88ad5add)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(1222f9fc9e0b3f04499d9542e29e58b12d8c5f1b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102055/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>