<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105919/">http://git.reviewboard.kde.org/r/105919/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Bart Cerneels and Myriam Schweingruber.</div>
<div>By Matěj Laitl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">StatSyncing: move configuration to standard Configure Amarok.. dialog
...to a newly created Metadata page.
configdialog: split metadata options into separate category
...the Local Collection page was too crowded and I will add stats
synchronization to Metadata page
ConfigDialog: formatting
StatSyncing: fix "Synchronizing Track Statistics" job progress bar
StatSyncing: make Provider QSharedData
...and everywhere reference it using QExplicitlySharedDataPointer. This
makes its memory management less error-prone.
StatSyncing: introduce ScrobblingService, adapt Last.fm ScrobblerAdapter
This makes StatSyncing::Controller handle scrobbling, too. Abstract
Base Class ScrobblingService is introduced, lastfm ScrobblerAdapter is
made a subclass of it.
This means that it is now possible to plug multiple (different)
scrobbling services, for example libre.fm in future.
ScrobblerAdapter: set correct timestamp when scrobbling
UmsCollection: More unique collectionId()
useful for StatSyncing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(8596144087709d9baab19b63c35f0c8169dca427)</span></li>
<li>src/configdialog/ConfigDialog.cpp <span style="color: grey">(dec537ff4fa6dfd8ef7008cc0afb50269d5d0a9d)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.h <span style="color: grey">(3229436efaffd443959b0d820f9437636e5111a1)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: grey">(fb326fcdfd474c7340a9f13f80e211b49a23b339)</span></li>
<li>src/dialogs/CollectionSetup.h <span style="color: grey">(23d717ac386f9d1893a00c75e0972c0c35adf2f9)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(cc3b756d9029c771b7da2cda74b6171dff45c9dc)</span></li>
<li>src/services/lastfm/LastFmService.h <span style="color: grey">(ac13d41cc5fd626a3ed6cb306d0969ef320c0c09)</span></li>
<li>src/services/lastfm/LastFmService.cpp <span style="color: grey">(a14d989b3fac81e545df095adee36580b052fea7)</span></li>
<li>src/services/lastfm/ScrobblerAdapter.h <span style="color: grey">(613ad9973b0d768a0345acbe801a72e2652c9c90)</span></li>
<li>src/services/lastfm/ScrobblerAdapter.cpp <span style="color: grey">(fa8635bb8c5492a2a434f6f947afa5f215124fee)</span></li>
<li>src/statsyncing/Config.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Config.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Options.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Process.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Process.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Provider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Provider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ScrobblingService.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ScrobblingService.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackTuple.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackTuple.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/SynchronizeTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/MatchedTracksModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/MatchedTracksModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/ProvidersModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/ProvidersModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/MatchedTracksPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/MatchedTracksPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>