<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105525/">http://git.reviewboard.kde.org/r/105525/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ca8caf38bdbd6cc0a424e9efdf316053105a2139 by Jasneet Singh Bhatti to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 24th, 2012, 4:32 p.m., Jasneet Bhatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Matěj Laitl and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated July 24, 2012, 4:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added unit test for core/meta/support/PrivateMetaRegistry.
Also, tidied up the code style in the class being tested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, links and runs fine.
Output of running test with -v2 flag:
********* Start testing of TestPrivateMetaRegistry *********
Config: Using QTest library 4.8.1, Qt 4.8.1
INFO : TestPrivateMetaRegistry::initTestCase() entering
QSYSTEM: TestPrivateMetaRegistry::initTestCase() qttest(16692)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned
PASS : TestPrivateMetaRegistry::initTestCase()
INFO : TestPrivateMetaRegistry::testInsertAlbum() entering
INFO : TestPrivateMetaRegistry::testInsertAlbum(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
PASS : TestPrivateMetaRegistry::testInsertAlbum()
INFO : TestPrivateMetaRegistry::testInsertArtist() entering
INFO : TestPrivateMetaRegistry::testInsertArtist(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
PASS : TestPrivateMetaRegistry::testInsertArtist()
INFO : TestPrivateMetaRegistry::testInsertComposer() entering
INFO : TestPrivateMetaRegistry::testInsertComposer(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
PASS : TestPrivateMetaRegistry::testInsertComposer()
INFO : TestPrivateMetaRegistry::testInsertGenre() entering
INFO : TestPrivateMetaRegistry::testInsertGenre(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
PASS : TestPrivateMetaRegistry::testInsertGenre()
INFO : TestPrivateMetaRegistry::testInsertYear() entering
INFO : TestPrivateMetaRegistry::testInsertYear(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
PASS : TestPrivateMetaRegistry::testInsertYear()
INFO : TestPrivateMetaRegistry::testNull() entering
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(165)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(166)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(167)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(168)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(169)]
PASS : TestPrivateMetaRegistry::testNull()
INFO : TestPrivateMetaRegistry::cleanupTestCase() entering
PASS : TestPrivateMetaRegistry::cleanupTestCase()
Totals: 8 passed, 0 failed, 0 skipped
********* Finished testing of TestPrivateMetaRegistry *********
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/meta/support/PrivateMetaRegistry.h <span style="color: grey">(f5959ac)</span></li>
<li>tests/core/meta/CMakeLists.txt <span style="color: grey">(3ae78c9)</span></li>
<li>tests/core/meta/support/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestPrivateMetaRegistry.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestPrivateMetaRegistry.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105525/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>