<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105454/">http://git.reviewboard.kde.org/r/105454/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 18th, 2012, 8:50 p.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105454/diff/3/?file=72593#file72593line25" style="color: black; font-weight: bold; text-decoration: underline;">src/core/meta/support/MetaKeys.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">TestMetaTrackKey</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same here: is this really needed? "friend class" should be enough IMO, but I'm too lazy to try. :-|</pre>
</blockquote>
<p>On July 20th, 2012, 10:29 a.m., <b>Jasneet Bhatti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TestMetaAlbumKey is declared in a global namespace.
So, to be able to add it as a friend class, we need to either do the explicit forward declaration as above and use the :: operator to refer to it
OR
do:
namespace
{
class TestMetaAlbumKey;
}
and then use it without the :: operator like any other class
Had it been declared in some user defined namespace, only the friend class declaration would have sufficed.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, then proceed with the original patch, same for the AlbumKey one.
Good work, Jasneet, your rate is amazing. If you ever want something more complicated then these easy core classes, there is SqlScanResultProcessor, QtGroupingProxy etc to test, but beware these may be rather complicated and time-consuming to test properly.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On July 14th, 2012, 4:06 a.m., Jasneet Bhatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Matěj Laitl and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated July 14, 2012, 4:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a unit test for class TrackKey of core/meta/support/MetaKeys</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, and runs fine.
Output of running test with -v2 flag:
********* Start testing of TestMetaTrackKey *********
Config: Using QTest library 4.8.1, Qt 4.8.1
INFO : TestMetaTrackKey::initTestCase() entering
PASS : TestMetaTrackKey::initTestCase()
INFO : TestMetaTrackKey::testOperatorAssignment() entering
QSYSTEM: TestMetaTrackKey::testOperatorAssignment() qttest(4918)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned
INFO : TestMetaTrackKey::testOperatorAssignment() QVERIFY(!( trackKey1 == trackKey2 ))
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaTrackKey.cpp(41)]
INFO : TestMetaTrackKey::testOperatorAssignment() QVERIFY(trackKey1 == trackKey2)
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaTrackKey.cpp(45)]
PASS : TestMetaTrackKey::testOperatorAssignment()
INFO : TestMetaTrackKey::cleanupTestCase() entering
PASS : TestMetaTrackKey::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of TestMetaTrackKey *********
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/meta/support/MetaKeys.h <span style="color: grey">(1a2fc25)</span></li>
<li>src/core/meta/support/MetaKeys.cpp <span style="color: grey">(d3fd722)</span></li>
<li>tests/core/meta/CMakeLists.txt <span style="color: grey">(3ae78c9)</span></li>
<li>tests/core/meta/support/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestMetaTrackKey.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestMetaTrackKey.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105454/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>