<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105525/">http://git.reviewboard.kde.org/r/105525/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, ship after fixing rahter small issues below. You should split this into 2 commits, first could be named: "PrivateMetaRegistry: style fixes"</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105525/diff/1/?file=72250#file72250line33" style="color: black; font-weight: bold; text-decoration: underline;">tests/core/meta/support/TestPrivateMetaRegistry.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class TestPrivateMetaRegistry : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">createTestData</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This doesn't have to be a slot, doesn't have to be public. It should rather be private non-slot.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105525/diff/1/?file=72251#file72251line39" style="color: black; font-weight: bold; text-decoration: underline;">tests/core/meta/support/TestPrivateMetaRegistry.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">TestPrivateMetaRegistry</span><span class="o">::</span><span class="n">datapath</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span><span class="o">&</span> <span class="n">relPath</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code style: spaces. I know, KDevelop works against us.. :-(</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105525/diff/1/?file=72251#file72251line165" style="color: black; font-weight: bold; text-decoration: underline;">tests/core/meta/support/TestPrivateMetaRegistry.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">165</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QCOMPARE</span><span class="p">(</span> <span class="n">PrivateMetaRegistry</span><span class="o">::</span><span class="n">instance</span><span class="p">()</span><span class="o">-></span><span class="n">album</span><span class="p">(</span> <span class="s">"invalid"</span><span class="p">,</span> <span class="s">"invalid"</span> <span class="p">).</span><span class="n">isNull</span><span class="p">(),</span> <span class="kc">true</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QVERIFY instead of all these QCOMPAREs?</pre>
</div>
<br />
<p>- Matěj</p>
<br />
<p>On July 12th, 2012, 1:10 p.m., Jasneet Bhatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Matěj Laitl and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated July 12, 2012, 1:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added unit test for core/meta/support/PrivateMetaRegistry.
Also, tidied up the code style in the class being tested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, links and runs fine.
Output of running test with -v2 flag:
********* Start testing of TestPrivateMetaRegistry *********
Config: Using QTest library 4.8.1, Qt 4.8.1
INFO : TestPrivateMetaRegistry::initTestCase() entering
QSYSTEM: TestPrivateMetaRegistry::initTestCase() qttest(16692)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned
PASS : TestPrivateMetaRegistry::initTestCase()
INFO : TestPrivateMetaRegistry::testInsertAlbum() entering
INFO : TestPrivateMetaRegistry::testInsertAlbum(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO : TestPrivateMetaRegistry::testInsertAlbum(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
PASS : TestPrivateMetaRegistry::testInsertAlbum()
INFO : TestPrivateMetaRegistry::testInsertArtist() entering
INFO : TestPrivateMetaRegistry::testInsertArtist(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO : TestPrivateMetaRegistry::testInsertArtist(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
PASS : TestPrivateMetaRegistry::testInsertArtist()
INFO : TestPrivateMetaRegistry::testInsertComposer() entering
INFO : TestPrivateMetaRegistry::testInsertComposer(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO : TestPrivateMetaRegistry::testInsertComposer(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
PASS : TestPrivateMetaRegistry::testInsertComposer()
INFO : TestPrivateMetaRegistry::testInsertGenre() entering
INFO : TestPrivateMetaRegistry::testInsertGenre(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO : TestPrivateMetaRegistry::testInsertGenre(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
PASS : TestPrivateMetaRegistry::testInsertGenre()
INFO : TestPrivateMetaRegistry::testInsertYear() entering
INFO : TestPrivateMetaRegistry::testInsertYear(Track01.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Track02.ogg) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Platz 01.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Platz 02.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO : TestPrivateMetaRegistry::testInsertYear(Platz 03.mp3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
PASS : TestPrivateMetaRegistry::testInsertYear()
INFO : TestPrivateMetaRegistry::testNull() entering
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(165)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(166)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(167)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(168)]
INFO : TestPrivateMetaRegistry::testNull() COMPARE()
Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(169)]
PASS : TestPrivateMetaRegistry::testNull()
INFO : TestPrivateMetaRegistry::cleanupTestCase() entering
PASS : TestPrivateMetaRegistry::cleanupTestCase()
Totals: 8 passed, 0 failed, 0 skipped
********* Finished testing of TestPrivateMetaRegistry *********
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/core/meta/support/TestPrivateMetaRegistry.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/CMakeLists.txt <span style="color: grey">(3ae78c9)</span></li>
<li>tests/core/meta/support/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestPrivateMetaRegistry.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/meta/support/PrivateMetaRegistry.h <span style="color: grey">(f5959ac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105525/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>