<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105285/">http://git.reviewboard.kde.org/r/105285/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Zhengliang Feng.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the latest diff between my work and master branch of Amarok.
Currently this has the following problems:
1. Slot SpotifyQueryMaker::collectResults() will never be executed, I thought it is because the SpotifyQueryMaker is deleted before the results are returned. I added addToCollection() in Query::tracksAdded() to work around this.
2. The results are added to collection correctly, but sometimes the results don't show up in the collection browser.
3. The 'length' or 'duration' of a track is always 0, maybe it's a problem of Spotify resolver.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Things I've done this week:
* Added a new playlist provider SpotifyPlaylistProvider
* Added playlist class SpotifyPlaylist
* Clear all extra whitespaces
* Figured out how Collection, QueryMaker and Playlist worked
Things need to be done next week:
* Clean ScriptResolver's interfaces, move all query related interfaces into Query class
* Replace Controller class with ScriptResolver
* Test SpotifyCollection
* Finish playlist and playlist provider</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No test done this week. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/CMakeLists.txt <span style="color: grey">(c78b920)</span></li>
<li>src/core-impl/collections/spotifycollection/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyPlaylist.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Query.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Query.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>