<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105454/">http://git.reviewboard.kde.org/r/105454/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Amarok, MatÄ›j Laitl and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>


<p style="color: grey;"><i>Updated July 11, 2012, 8:49 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added output of running test in "Testing Done"</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a unit test for class TrackKey of core/meta/support/MetaKeys</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, and runs fine.

Output of running test with -v2 flag:

********* Start testing of TestMetaTrackKey *********
Config: Using QTest library 4.8.1, Qt 4.8.1
INFO   : TestMetaTrackKey::initTestCase() entering
PASS   : TestMetaTrackKey::initTestCase()
INFO   : TestMetaTrackKey::testOperatorAssignment() entering
QSYSTEM: TestMetaTrackKey::testOperatorAssignment() qttest(4918)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 
INFO   : TestMetaTrackKey::testOperatorAssignment() QVERIFY(!( trackKey1 == trackKey2 ))
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaTrackKey.cpp(41)]
INFO   : TestMetaTrackKey::testOperatorAssignment() QVERIFY(trackKey1 == trackKey2)
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaTrackKey.cpp(45)]
PASS   : TestMetaTrackKey::testOperatorAssignment()
INFO   : TestMetaTrackKey::cleanupTestCase() entering
PASS   : TestMetaTrackKey::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of TestMetaTrackKey *********
</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tests/core/meta/CMakeLists.txt <span style="color: grey">(3ae78c9)</span></li>

 <li>tests/core/meta/support/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/core/meta/support/TestMetaTrackKey.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/core/meta/support/TestMetaTrackKey.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105454/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>