<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105389/">http://git.reviewboard.kde.org/r/105389/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 66b58ca3e926b789a455e0243336f34496218e49 by Jasneet Singh Bhatti to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 11th, 2012, 7:36 p.m., Jasneet Bhatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Matěj Laitl and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated July 11, 2012, 7:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added unit test for core/collections/support/TrackForUrlWorker
Just the one slot completeJob() to test.
Tested for both KUrl and QString types of urls.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and runs fine.
Output of "build/tests/testrackforurl -v2" :
********* Start testing of TestTrackForUrlWorker *********
Config: Using QTest library 4.8.1, Qt 4.8.1
INFO : TestTrackForUrlWorker::initTestCase() entering
PASS : TestTrackForUrlWorker::initTestCase()
INFO : TestTrackForUrlWorker::testCompleteJobKUrl() entering
QSYSTEM: TestTrackForUrlWorker::testCompleteJobKUrl() qttest(14218)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) QVERIFY(trackForUrlWorker)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(58)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) QVERIFY(receivedDone)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 1) QVERIFY(receivedDestroyed)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) QVERIFY(trackForUrlWorker)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(58)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) QVERIFY(receivedDone)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 2) QVERIFY(receivedDestroyed)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) QVERIFY(trackForUrlWorker)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(58)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) QVERIFY(receivedDone)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)]
INFO : TestTrackForUrlWorker::testCompleteJobKUrl(track 3) QVERIFY(receivedDestroyed)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)]
PASS : TestTrackForUrlWorker::testCompleteJobKUrl()
INFO : TestTrackForUrlWorker::testCompleteJobQString() entering
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) QVERIFY(trackForUrlWorker)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(74)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) QVERIFY(receivedDone)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 1) QVERIFY(receivedDestroyed)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) QVERIFY(trackForUrlWorker)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(74)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) QVERIFY(receivedDone)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 2) QVERIFY(receivedDestroyed)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) QVERIFY(trackForUrlWorker)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(74)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) QVERIFY(receivedDone)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(101)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(104)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) COMPARE()
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(108)]
INFO : TestTrackForUrlWorker::testCompleteJobQString(track 3) QVERIFY(receivedDestroyed)
Loc: [/home/jasneet/amarok/tests/core/collections/support/TestTrackForUrlWorker.cpp(112)]
PASS : TestTrackForUrlWorker::testCompleteJobQString()
INFO : TestTrackForUrlWorker::cleanupTestCase() entering
PASS : TestTrackForUrlWorker::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
********* Finished testing of TestTrackForUrlWorker *********
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/core/collections/CMakeLists.txt <span style="color: grey">(b01b655)</span></li>
<li>tests/core/collections/support/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/collections/support/TestTrackForUrlWorker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/collections/support/TestTrackForUrlWorker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/mocks/MockTrackForUrlWorker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/mocks/MockTrackForUrlWorker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105389/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>