<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105424/">http://git.reviewboard.kde.org/r/105424/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Ralf Engels, Matěj Laitl, and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a unit test for core/meta/support/MetaConstants
Corrected a couple of minor code style issues I came across in another test.
This test has some lines longer than 90 characters because they look more elegant that way in the context, although I could break them should that be an issue.
testValueForField() uses some existing Mock classes with the addition of MockLabel. The rest of the test methods use data driven testing.
I also have a doubt regarding the intention behind a statement in 'case 0' of valueForField() in MetaConstants.cpp :
allInfos += track->playableUrl().path()
+= track->name()
+= track->comment();
This statement concatenates the three strings and adds them as one entity in the set allInfos, although it appears to me that the intention was to add them separately.
Ralf, since you authored it, I think you'd be the best person to clarify my doubt :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and runs fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/TestTrackOrganizer.h <span style="color: grey">(47fc22b)</span></li>
<li>tests/TestTrackOrganizer.cpp <span style="color: grey">(72e7b9b)</span></li>
<li>tests/core/meta/CMakeLists.txt <span style="color: grey">(3ae78c9)</span></li>
<li>tests/core/meta/support/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestMetaConstants.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/support/TestMetaConstants.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/mocks/MetaMock.h <span style="color: grey">(b478c87)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105424/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>