<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105409/">http://git.reviewboard.kde.org/r/105409/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Bart Cerneels and Myriam Schweingruber.</div>
<div>By Matěj Laitl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">StatSyncing: better sizeHint()s, UI fixes, clean-ups
StatSyncing: paint rating beautifully using stars
StatSyncing: implement auto-synchronize on startup and collection appearance
Only collections previously checked and collections that are
synchronized by default (Local and iPod collections currently) and not
unchecked participate in automatic synchronization.
StatSyncing: Implement saving of synchronized providers and fields
plus reduce heuristics so that stats of UMSCollection can be tried too.
StatSyncing: Back button in the matched tracks dialog
plus cleanup some memory management etc.
StatSyncing: GUI: add page for the first step of the synchronization
* Providers can be chosen
* Fields can be chosen
* Additional info is displayed
Revert Meta::Track::recentPlayCount() addition, use Capability instead
RecentStatsCapability is introduced by this commit and implemented by
IpodMeta, StatSyncing is adapted to it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything works as described and documented AFAICS.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(260e50bc208a81a963796048ada1856f0f8aaa08)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodMeta.h <span style="color: grey">(df6d70b70ee9464218705c9a3a1c54d339884ce1)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodMeta.cpp <span style="color: grey">(6d6e63cc9cb3c4b3072119aae4e61266b461714d)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.h <span style="color: grey">(e5d7266840ca244c884e1c397258e9d4d1a961de)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(091f5f6b484c8a8f66111d8a251c76f08ed2e632)</span></li>
<li>src/core-impl/collections/support/MemoryMeta.h <span style="color: grey">(6641e31743c1b0280a00d0090d64da0f7251739e)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(0579d08152792465c9b002fd66f625e7c4c18b2f)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(51299f827e11ccaace9c8ffb012780c1b7db30b6)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(8dc23587650c2e0ccdfc7b83a74fd69f1ac56b11)</span></li>
<li>src/core/capabilities/Capability.h <span style="color: grey">(8ec6d1630b7622b07cd2b613866b2125c6f91214)</span></li>
<li>src/core/capabilities/RecentStatsCapability.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/capabilities/RecentStatsCapability.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/meta/Meta.h <span style="color: grey">(a35d67f8f082bdf17fe850c485291ff04ab8477a)</span></li>
<li>src/core/meta/Meta.cpp <span style="color: grey">(5a175d54620d4e0b77bc8e836bf019bfc6a6577c)</span></li>
<li>src/statsyncing/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Process.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Process.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Provider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Provider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackTuple.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackTuple.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/SynchronizeTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/SynchronizeTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/CommonModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/CommonModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/MatchedTracksModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/MatchedTracksModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/ProvidersModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/ProvidersModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/SingleTracksModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/MatchedTracksPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/MatchedTracksPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/TrackDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/TrackDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105409/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>