<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105291/">http://git.reviewboard.kde.org/r/105291/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 19th, 2012, 1:21 p.m., <b>Sven Krohlas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You need to add ${QT_QTGUI_LIBRARY} to the target_link_libraries: target_link_libraries( testmetacapability ${KDE4_KDECORE_LIBS} ${QT_QTTEST_LIBRARY} ${QT_QTGUI_LIBRARY} amarokcore )
to avoid:
/usr/lib/gcc/i586-suse-linux/4.6/../../../../i586-suse-linux/bin/ld: CMakeFiles/testmetacapability.dir/TestMetaCapability.o: undefined reference to symbol 'QAction::QAction(QObject*)'
/usr/lib/gcc/i586-suse-linux/4.6/../../../../i586-suse-linux/bin/ld: note: 'QAction::QAction(QObject*)' is defined in DSO /usr/lib/libQtGui.so.4 so try adding it to the linker command line
/usr/lib/libQtGui.so.4: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[2]: *** [tests/testmetacapability] Fehler 1
make[1]: *** [tests/core/meta/CMakeFiles/testmetacapability.dir/all] Fehler 2
And then ship it. :)</pre>
</blockquote>
<p>On June 19th, 2012, 2:07 p.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh yes, QAction dependency was added atop of my exaple patch I sent. Jasneet, did you really test your patch befere posting it here? You would have faced this error if you did.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it twice and it was building just fine. And it baffled me too that Sven faced this error and not me until he said it was probably because cmake sometimes doesn't detect changes to cmake files and the older version had several more link targets including this one.</pre>
<br />
<p>- Jasneet</p>
<br />
<p>On June 19th, 2012, 2:02 p.m., Jasneet Bhatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Bart Cerneels, Matěj Laitl, and Sven Krohlas.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated June 19, 2012, 2:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit Test for class MetaCapability of core/meta/Meta</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit Test builds and runs as desired</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/core/meta/CMakeLists.txt <span style="color: grey">(0e85d83)</span></li>
<li>tests/core/meta/TestMetaCapability.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/meta/TestMetaCapability.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105291/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>