<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105201/">http://git.reviewboard.kde.org/r/105201/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One minor comment:
Please don't remove copyright headers when copying files from another project--this is important for both legal and authorship (e.g. "who do I ask when this code doesn't work") reasons. The ScriptResolver.* files come from Tomahawk, and I'm totally happy with you re-using the code that we wrote. However, you need to retain the same copyright header that exists in the original source file, and additionally adding your own copyright if you modify the file. This is the original:
https://github.com/tomahawk-player/tomahawk/blob/master/src/libtomahawk/resolvers/ScriptResolver.cpp
This is also why the ScriptResolver class supports external .js and non-spotify resolvers. It'll work with any external process that implements the playdar + tomahawk extensions resolver API.
thanks!</pre>
<br />
<p>- Leo</p>
<br />
<p>On June 10th, 2012, 7:10 a.m., Zhengliang Feng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Zhengliang Feng.</div>
<p style="color: grey;"><i>Updated June 10, 2012, 7:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add Spotify collection code
Currently implemented SpotifyCollection, SpotifyQueryMaker and
SpotifyMeta. The ScriptResolver is the class handles communcation with
standalone Spotify resolver, the code is mainly from original
ScriptResolver, but added more functions to handle messages separately.
The controller class is used to start a ScriptResolver in a separate
thread and handles queries.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ).
Logging into Spotify using a username and password.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/CMakeLists.txt <span style="color: grey">(c78b9202ece71b51189c4e47d85acfa4a74ef8d6)</span></li>
<li>src/core-impl/collections/spotifycollection/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/Query.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/ScriptResolver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105201/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>