<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105073/">http://git.reviewboard.kde.org/r/105073/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 28th, 2012, 3:19 p.m., <b>Sam Lade</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note that this change breaks compatibility with ffmpeg 0.6 and earlier. The readme would need updating (it's the MusicBrainz section of the dependencies) to reflect that ffmpeg/libav 0.7 is now required.
Furthermore, 0.7 was only released in June 2011 - are we okay with requiring a version this recent? We discussed this before and were planning to make the changes after release of Amarok 2.6, but that was before ffmpeg had rolled out a release breaking this. It may need #ifdefing.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree on that one. Now if the FFMPEG people could learn a bit on how not to break their own API on every release it would also be helpful...
Could we agree on the fix pre-2.6 to not break compatibility with versions before 0.7? We will have to re-discuss this again after 2.6 is released anyway.</pre>
<br />
<p>- Myriam</p>
<br />
<p>On May 27th, 2012, 10:28 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Sergey Ivanov.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated May 27, 2012, 10:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes two issues:
- replace deprecated av_open_input_file()
- replace toAscii() with toLocal8Bit()
This does not replace other deprecated calls to help building with older ffmpeg.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, but do not know how to test.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=300729">300729</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/musicbrainz/MusicDNSAudioDecoder.cpp <span style="color: grey">(0fa1946)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105073/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>