<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103694/">http://git.reviewboard.kde.org/r/103694/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still waiting for feedback....</pre>
<br />
<p>- Ralf</p>
<br />
<p>On January 14th, 2012, 2:20 p.m., Shlomi Fish wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Shlomi Fish.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2012, 2:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a patch to https://bugs.kde.org/show_bug.cgi?id=267319 , where Amarok refuses to enqueue many media file types that are supported by the Phonon backend.
It fixes the problem on Amarok by instantiating a
Phonon::MediaObject object and trying to see if it can load the local file. It
comes with the following reservations:
1. With Phonon-VLC all files (including non-media ones) are accepted. This
appears to affect dragonplayer as well, and seems to be a Phonon::MediaObject's
->setCurrentSource() related bug. ( I'll report it later. )
2. I didn't try to enqueue playlist files yet.
3. On my x86-64 Mageia Linux cauldron laptop, the phonon-gstreamer backend
often crashes Amarok. However, the same files also crash gst123.
4. I added some traces there to test something back when I was using phonon-vlc
- they are no longer needed.
Anyway, please look into it and see if you like the direction I'm taking.
Regards,
-- Shlomi Fish</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EngineController.cpp <span style="color: grey">(81f39b7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103694/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>