<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104693/">http://git.reviewboard.kde.org/r/104693/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104693/diff/1/?file=58366#file58366line1015" style="color: black; font-weight: bold; text-decoration: underline;">src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1015</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> if( TAGLIB_FOUND )</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a block linking the taglib just a few lines previously.
Around 922
Why do you need that here?</pre>
</div>
<br />
<p>- Ralf</p>
<br />
<p>On April 22nd, 2012, 5:25 p.m., Mathias Stephan Panzenböck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Mathias Stephan Panzenböck.</div>
<p style="color: grey;"><i>Updated April 22, 2012, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I installed TagLib 1.8-GIT in $HOME so I can try the new features (see also my other review request #101598). $HOME/bin is in $PATH and thus "taglib-config" returns all the right settings. Still Amarok did not compile. The reason is that it adds the taglib include directory to the list of include directories, but then still accesses the taglib headers with "#include <taglib/tstring.h>" in some places (instead of using "#include <tstring.h>"). This is clearly wrong, but coincidentally works if taglib is installed in /usr. I fixed that.
For some reason which I can't explain I had to also add the taglib libs to the amarok binary. I would have thought that adding it to amaroklib would be enough, but then the linker complained.
Maybe the patch isn't good like it is (the linking part), but something needs to be done about this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/tag_helpers/APETagHelper.h <span style="color: grey">(c9f23c7)</span></li>
<li>shared/tag_helpers/ASFTagHelper.h <span style="color: grey">(41b58b2)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: grey">(1bbae70)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(27e0cf0)</span></li>
<li>shared/tag_helpers/MP4TagHelper.h <span style="color: grey">(9a6beee)</span></li>
<li>shared/tag_helpers/StringHelper.h <span style="color: grey">(3f6b9b8)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.h <span style="color: grey">(5c5b1bf)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(1fbb437)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(43bda90)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104693/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>