<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104839/">http://git.reviewboard.kde.org/r/104839/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 3rd, 2012, 8:40 p.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, it indeed doesn't work with newer ffmpeg, I faced this too, but was too lazy to fix it. However, from what I've seen -map_meta_data was just renamed to -map_metadata and I don't know if it is enabled by default. Could you please point me to the relevant poiece of ffmpeg documentation that says so? If it is confirmed, I'll be happy to merge this.</pre>
</blockquote>
<p>On May 3rd, 2012, 8:50 p.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">...the transcoding doesn't work with newer ffmpeg, the patch is fine. (sorry for bad wording)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is indeed a map_metadata option that performs a similar task to map_meta_data. However it also has a different syntax (it uses integer file indexes instead of filenames). From the ffmpeg manual :
-map_metadata[:metadata_spec_out] infile[:metadata_spec_in] (output,per-metadata)
Set metadata information of the next output file from infile. Note that those are file indices
(zero-based), not filenames. Optional metadata_spec_in/out parameters specify, which metadata to
copy.
And a little bit below that:
By default, global metadata is copied from the first input file, per-stream and per-chapter
metadata is copied along with streams/chapters. These default mappings are disabled by creating
any mapping of the relevant type.
I did test this and at least for converting from FLAC to ALAC it works as expected. I believe these options only exist for more complex file types such as a .mkv file with video and multiple audio streams (say multiple languages or number of channels). As far as I can tell, for simply transcoding audio, we shouldn't have to worry about any of this, but if someone can think of a counterexample I'm sure we can make it work.</pre>
<br />
<p>- Julian</p>
<br />
<p>On May 3rd, 2012, 11:07 a.m., Julian Simioni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Julian Simioni.</div>
<p style="color: grey;"><i>Updated May 3, 2012, 11:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While it seemed to work a while ago (before it was merged to trunk), I recently found that the new ipod manager cannot transcode tracks when sending them to my iPod. I spent some time debugging it and was able to find the cause:
The -map_meta_data option was depricated as of ffmpeg 0.7 and removed in 0.10. Additionally, as far as I can tell the options specified did nothing but explicitly confirm the default option of copying infile metadata to outfile metadata. Please let me know if I'm mistaken about this conclusion.
I also made some small changes to the debug output that should make things slightly cleaner.
When pulling, please use branch fixTranscode at git://github.com/orangejulius/amarok.git as it has separate commits ready to go :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested transcoding FLAC music files to ALAC while copying to my iPod classic 160GB</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/transcoding/TranscodingJob.cpp <span style="color: grey">(5b30c44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>