<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104513/">http://git.reviewboard.kde.org/r/104513/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, push! You can improve the UI later if somebody comes with a suggestion.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On April 13th, 2012, 7:42 p.m., Daniel Faust wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 7:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch includes a list of small changes that are supposed to give the user more control over the cover writing process and unify it for all file formats.
1. The user can set the maximum cover size in the config dialog instead of having a fixed 200px. (BR 279493)
2. The user can set how existing covers should be handled:
- 'Replace existing front covers' (almost the current behavior except for m4a files and some cases where more than one 'front' cover exists)
- 'Replace all existing covers'
- 'Append new cover' (actually it's a prepend, doesn't work with wma files, though; the current behavior for m4a files)
3. Unify the reading of covers. Instead of searching for the biggest cover like it was implemented for some file formats from now on the first 'front' cover will be taken. If there is no 'front' cover, the first 'other' cover will be taken (if present). The 1kb limit is still present.
4. Fix a potential bug where covers couldn't be found in mp3 files if the first cover was neither a 'front' cover nor 'other' or smaller than 1kb.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested writing covers with flac, mp3, and wma files.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=279493">279493</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey">(93e6031)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(27e0cf0)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey">(faeae0a)</span></li>
<li>shared/tag_helpers/TagHelper.h <span style="color: grey">(f8e7fd9)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(1fbb437)</span></li>
<li>src/amarokconfig.kcfg <span style="color: grey">(5610c4a)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(e663adf)</span></li>
<li>src/dialogs/CollectionSetup.h <span style="color: grey">(3146f17)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(f1b7850)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104513/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104513/s/508/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/08/cover_art_handling_2_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/104513/s/514/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/10/amarok-write-covers-config-mockup_400x100.png" style="border: 1px black solid;" alt="Mockup of a possible gui for setting cover size. I must say I'm not a big fan of this." /></a>
<a href="http://git.reviewboard.kde.org/r/104513/s/515/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/10/amarok-write-covers-config-mockup_1_400x100.png" style="border: 1px black solid;" alt="Mockup of a possible GUI to configure cover size. I'm not a big fan of this." /></a>
<a href="http://git.reviewboard.kde.org/r/104513/s/527/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/13/cover_art_handling_4_cut_400x100.png" style="border: 1px black solid;" alt="Still not perfect but better, I hope" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>