<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104513/">http://git.reviewboard.kde.org/r/104513/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2012, 1:55 p.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Overall I think this is a lot of config for a pretty esoteric feature. It's nice to have embedded covers, but can't we implement a default that works for the 98%?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem why I implemented the 'overwrite mode' option was that it was rather chaotic what would happen if you had an 'other' cover and let amarok write a 'front' cover. But as Matěj wrote he prefers the 'overwrite all covers', too. So maybe we can agree on that? My initial idea was that I don't want to break the current behavior.
And as I think more about it, with all the other changes I made to the loading process it might actually be a little bit redundant. The use case I had in mind was that if the file already contained an 'other' cover, amarok would add the new 'front' cover but wouldn't use it if the 'other' cover was bigger. So if everybody agrees with the new loading we could drop that config option.
Also I would like to say that for me embedded covers is not just a nice to have. When I organize my collection I want to make it properly and 200px covers don't do it justice.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2012, 1:55 p.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104513/diff/1/?file=56168#file56168line355" style="color: black; font-weight: bold; text-decoration: underline;">shared/tag_helpers/ID3v2TagHelper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ID3v2TagHelper::embeddedCover() const</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QImage</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">347</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">ID3v2TagHelper</span><span class="o">::</span><span class="n">embeddedCover</span><span class="p">()</span> <span class="k">const</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">355</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">ID3v2TagHelper</span><span class="o">::</span><span class="n">embeddedCover</span><span class="p">()</span> <span class="k">const</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any caching of this cover higher up in the stack?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What do you mean?</pre>
<br />
<p>- Daniel</p>
<br />
<p>On April 10th, 2012, 5:01 p.m., Daniel Faust wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated April 10, 2012, 5:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch includes a list of small changes that are supposed to give the user more control over the cover writing process and unify it for all file formats.
1. The user can set the maximum cover size in the config dialog instead of having a fixed 200px. (BR 279493)
2. The user can set how existing covers should be handled:
- 'Replace existing front covers' (almost the current behavior except for m4a files and some cases where more than one 'front' cover exists)
- 'Replace all existing covers'
- 'Append new cover' (actually it's a prepend, doesn't work with wma files, though; the current behavior for m4a files)
3. Unify the reading of covers. Instead of searching for the biggest cover like it was implemented for some file formats from now on the first 'front' cover will be taken. If there is no 'front' cover, the first 'other' cover will be taken (if present). The 1kb limit is still present.
4. Fix a potential bug where covers couldn't be found in mp3 files if the first cover was neither a 'front' cover nor 'other' or smaller than 1kb.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested writing covers with flac, mp3, and wma files.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=279493">279493</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey">(93e6031)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(27e0cf0)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey">(faeae0a)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(1fbb437)</span></li>
<li>src/amarokconfig.kcfg <span style="color: grey">(5610c4a)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(e663adf)</span></li>
<li>src/dialogs/CollectionSetup.h <span style="color: grey">(3146f17)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(f1b7850)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104513/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104513/s/508/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/08/cover_art_handling_2_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/104513/s/514/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/10/amarok-write-covers-config-mockup_400x100.png" style="border: 1px black solid;" alt="Mockup of a possible gui for setting cover size. I must say I'm not a big fan of this." /></a>
<a href="http://git.reviewboard.kde.org/r/104513/s/515/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/10/amarok-write-covers-config-mockup_1_400x100.png" style="border: 1px black solid;" alt="Mockup of a possible GUI to configure cover size. I'm not a big fan of this." /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>