<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104423/">http://git.reviewboard.kde.org/r/104423/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That makes sense and simple implementation as well. It safe to assume track numbers are getting corrected if wrong.</pre>
<br />
<p>- Bart</p>
<br />
<p>On March 27th, 2012, 6:16 a.m., Alexey Neyman wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Alexey Neyman.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 6:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In merged view, amarok merges the tracks if the tracks in an album have the same
title even though they have different track number. It does not do so when shown
collections separately. As far as I understand, the merged view is supposed to
eliminate identical tracks - but tracks with different track numbers are obviously
not identical.
A couple of examples where album has more than one track with same name:
- I have a concert recording where between the songs there are author's commentaries.
Naturally, there are 11 tracks titled "Commentary"
- Classical pieces often have parts titled by the tempo, e.g. track #2 "Allegro".
Oftentimes there's more than one part with the same tempo in a piece.
This patch adds track number to Meta::TrackKey class - the ProxyCollection class
which implements merged view uses Meta::TrackKey to determine if tracks are
identical.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/meta/support/MetaKeys.h <span style="color: grey">(e2227e6)</span></li>
<li>src/core/meta/support/MetaKeys.cpp <span style="color: grey">(7f8ce7d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104423/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>