<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103603/">http://git.reviewboard.kde.org/r/103603/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103603/diff/5/?file=48221#file48221line41" style="color: black; font-weight: bold; text-decoration: underline;">src/browsers/AbstractTreeViewDelegate.h</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class AbstractTreeViewDelegate : public QStyledItemDelegate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QFontMetrics</span> <span class="o">*</span><span class="n">bigFm</span><span class="p">()</span> <span class="k">const</span> <span class="p">{</span> <span class="k">return</span> <span class="n">m_bigFm</span><span class="p">;</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would be more verbose here:
bigFontMetrics();
smallFontMetrics();</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103603/diff/5/?file=48223#file48223line204" style="color: black; font-weight: bold; text-decoration: underline;">src/browsers/CollectionTreeItemModelBase.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">CollectionTreeItemModelBase::dataForItem( CollectionTreeItem *item, int role, int level ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">rowHeight</span> <span class="o"><</span> <span class="mi">3<span class="hl">4</span></span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">rowHeight</span> <span class="o"><</span> <span class="mi">3<span class="hl">2</span></span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I fooled you in a bad way, I wanted to say that the height should be left at 34 pixels (i.e. untouched).</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you please explain what are the benefits (direct, current - not hypothetical or philosofical) of the TreeItem -> NormalTreeItem, MergedTreeItem split? Where exactly is avoids code duplication?</pre>
<p>- Matěj</p>
<br />
<p>On January 29th, 2012, 6:42 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2012, 6:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my attempt to make QTreeView subclasses items, used in Amarok, more pretty by displaying some extra information. Notice that these extra information are usually the quantity of tracks in a album, the quantity of episodes in a podcast and the quantity of episodes marked as new in a podcast.
So, please help me to improve this feature even more by answering some questions:
1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser too?
2) Is there any extra information that you think it's relevant to be showed somewhere (In QTreeViews)?
Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch should build. Everything is working as expected and there aren't any known issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp <span style="color: grey">(35a8222)</span></li>
<li>src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(e7f8e62)</span></li>
<li>ChangeLog <span style="color: grey">(70dd420)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4241e69)</span></li>
<li>src/browsers/AbstractTreeViewDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/AbstractTreeViewDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionTreeItemDelegate.h <span style="color: grey">(8a189e6)</span></li>
<li>src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp <span style="color: grey">(755be00)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: grey">(ac1c26d)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserCategory.h <span style="color: grey">(9198d43)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp <span style="color: grey">(0c2f9c1)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserView.cpp <span style="color: grey">(9c4236d)</span></li>
<li>src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h <span style="color: grey">(3a094b0)</span></li>
<li>src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp <span style="color: grey">(bc76551)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsByProviderProxy.h <span style="color: grey">(941268c)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp <span style="color: grey">(12f2676)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h <span style="color: grey">(9a01dbe)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp <span style="color: grey">(4268a82)</span></li>
<li>src/browsers/playlistbrowser/PodcastCategory.cpp <span style="color: grey">(1c353dc)</span></li>
<li>src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: grey">(e88f4a1)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(18334f6)</span></li>
<li>src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/UserPlaylistCategory.cpp <span style="color: grey">(b48a55f)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(42ad039)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(1c3bdf4)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(679f7ac)</span></li>
<li>src/core/podcasts/PodcastMeta.cpp <span style="color: grey">(b9851f7)</span></li>
<li>src/widgets/TrackSelectWidget.cpp <span style="color: grey">(5bd5059)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103603/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103603/s/420/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/27/collectionBrowser_400x100.jpeg" style="border: 1px black solid;" alt="CollectionBrowser" /></a>
<a href="http://git.reviewboard.kde.org/r/103603/s/423/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/29/podcastBrowser_400x100.jpeg" style="border: 1px black solid;" alt="PodcastBrowser" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>