<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104335/">http://git.reviewboard.kde.org/r/104335/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still can't test because of 503 error on gpodder.net/api.
Code is good.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104335/diff/1-2/?file=53770#file53770line784" style="color: black; font-weight: bold; text-decoration: underline;">src/services/gpodder/GpodderProvider.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 1 - 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GpodderProvider::deviceUpdatesParseError()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">784</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Amarok</span><span class="o">::</span><span class="n">Components</span><span class="o">::</span><span class="n">logger</span><span class="p">()</span><span class="o">-></span><span class="n">shortMessage</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"GPodder Service failed to get data from the server. Will retry in 10 seconds..."</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note to self: use Solid::Networking::status() to prevent offline running of that 10 second loop.</pre>
</div>
<br />
<p>- Bart</p>
<br />
<p>On March 19th, 2012, 8 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated March 19, 2012, 8 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GPodder Improvements Patch Rev1
Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.
GPodder Service improvements
Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch should build. Everything is working as expected and there aren't any known issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp <span style="color: grey">(0a450ae2420de11ab221cf2dec9fc942a7118dd1)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: grey">(e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(18334f6eb970eed241f172cc71396cca8bcaf04b)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.h <span style="color: grey">(c3d5e56e79c86e2be8c39f47df928bfeb291a920)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(183005f652989167952b0c8cf16e742de2fb94e1)</span></li>
<li>src/services/gpodder/GpodderPodcastRequestHandler.h <span style="color: grey">(8c12e5f5a5a63b91670fd8081018b7a017a00bbe)</span></li>
<li>src/services/gpodder/GpodderPodcastRequestHandler.cpp <span style="color: grey">(66e8ea8a3aeec054c82a180f84d199aba5547f5a)</span></li>
<li>src/services/gpodder/GpodderProvider.h <span style="color: grey">(4c724cd763b94515e9e90620ad9a4a3fb8f92e2c)</span></li>
<li>src/services/gpodder/GpodderProvider.cpp <span style="color: grey">(6e3255e5f465287a9fad3454cca5a1d2ce47fc6a)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(b518de33e01d20c7293c50e9edbb2dff78419e53)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.h <span style="color: grey">(111455aeeb2a579caf1dd938249b8d832a775a89)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: grey">(750272e4f2c6c7ad411e9d12c622e97789a29bcd)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: grey">(81bc218428d2b8bc78235852548a337579b35b24)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: grey">(8bb8b806927d1dbac47f2a06887c2e2a6dd3d504)</span></li>
<li>src/services/gpodder/GpodderSortFilterProxyModel.h <span style="color: grey">(638fe992cba553cc317febdf049b6b0f301018b5)</span></li>
<li>src/services/gpodder/GpodderSortFilterProxyModel.cpp <span style="color: grey">(ed1e8301f6f415e86e5367b7827817fff45feb98)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104335/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>